Re: [PATCH] drm: Fix an unwanted master inheritance v2

[Jani Nikula <jani.nikula@linux.intel.com>]

On Thu, 03 Dec 2015, Thomas Hellstrom <thellstrom@vmware.com> wrote:
> Hi,
>
> On 12/03/2015 12:12 PM, Jani Nikula wrote:
>> On Wed, 02 Dec 2015, Thomas Hellstrom <thellstrom@vmware.com> wrote:
>>> A client calling drmSetMaster() using a file descriptor that was opened
>>> when another client was master would inherit the latter client's master
>>> object and all its authenticated clients.
>>>
>>> This is unwanted behaviour, and when this happens, instead allocate a
>>> brand new master object for the client calling drmSetMaster().
>>>
>>> Fixes a BUG() throw in vmw_master_set().
>>>
>>> Cc: <stable@vger.kernel.org>
>>> Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
>> Drive-by bikeshedding, the actual change might look neater (and easier
>> to revert if something falls apart) if you extracted the
>> drm_new_set_master() abstraction as a separate non-functional prep
>> patch. Not insisting, just a thought.
>>
>> BR,
>> Jani.
> While you're probably right, I prefer to have this as a single patch to
> avoid ending up in a backporting nightmare for stable.

That's reasonable.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center