From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39700)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1a4VqA-0006sY-DL
	for qemu-devel@nongnu.org; Thu, 03 Dec 2015 10:30:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1a4Vq6-0002SI-Cc
	for qemu-devel@nongnu.org; Thu, 03 Dec 2015 10:30:38 -0500
From: Markus Armbruster <armbru@redhat.com>
Date: Thu, 03 Dec 2015 16:30:31 +0100
Message-ID: <87bna7v9bc.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: [Qemu-devel] Posible regressions around spapr-dr-connector property
	drc-connector[]
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, agraf@suse.de, david@gibson.dropbear.id.au

1. Before commit 94649d4 "spapr: Don't use QOM [*] syntax for DR
   connectors", the indexes were small integers:

       (qemu) info qom-tree
       /machine (pseries-2.4-machine)
         /unattached (container)
           [...]
           /device[5] (spapr-pci-host-bridge)
             /pci@800000020000000.mmio[0] (qemu:memory-region)
             /pci@800000020000000.mmio-alias[0] (qemu:memory-region)
             /pci@800000020000000.io[0] (qemu:memory-region)
             /pci@800000020000000.io-alias[0] (qemu:memory-region)
             /pci.0 (PCI)
             /pci@800000020000000.iommu-root[0] (qemu:memory-region)
             /dr-connector[0] (spapr-dr-connector)
             /dr-connector[1] (spapr-dr-connector)
             /dr-connector[2] (spapr-dr-connector)
             [...]

   Since then, they're big ones:

             /dr-connector[1073741824] (spapr-dr-connector)
             /dr-connector[1073741825] (spapr-dr-connector)
             /dr-connector[1073741826] (spapr-dr-connector)

   The commit message doesn't quite spell out this change, and I'm
   therefore double-checkint it's intentional.  Is it?

2. Before commit 6c2f9a1 "qapi: Make output visitor return qnull()
   instead of NULL", qom-get returned {}:

   Since then, it returns null:

       QMP> { "execute": "qom-get", "arguments": { "path": "/machine/unattached/device[5]/dr-connector[1073741950]", "property": "fdt" } }
       {"return": null}

   Does anyone care?