From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36528) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtvDJ-0004vP-BU for qemu-devel@nongnu.org; Wed, 04 Nov 2015 05:22:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtvDG-0000Dm-Nc for qemu-devel@nongnu.org; Wed, 04 Nov 2015 05:22:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33025) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtvDG-0000DT-Ib for qemu-devel@nongnu.org; Wed, 04 Nov 2015 05:22:42 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id B3DD2C100446 for ; Wed, 4 Nov 2015 10:22:41 +0000 (UTC) From: Markus Armbruster References: <1446618049-13596-1-git-send-email-eblake@redhat.com> Date: Wed, 04 Nov 2015 11:22:37 +0100 In-Reply-To: <1446618049-13596-1-git-send-email-eblake@redhat.com> (Eric Blake's message of "Tue, 3 Nov 2015 23:20:22 -0700") Message-ID: <87bnbarrma.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v9 00/27] alternate layout (post-introspection cleanups, subset C) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org Eric Blake writes: > No pending prerequisites; based on qemu.git master > > Also available as a tag at this location: > git fetch git://repo.or.cz/qemu/ericb.git qapi-cleanupv9c > > and will soon be part of my branch with the rest of the v5 series, at: > http://repo.or.cz/qemu/ericb.git/shortlog/refs/heads/qapi > > v9 notes: > More patches added, and several reorganized. Lots of new patches > from Markus, although not in the order originally proposed. > > The first 8 patches are fairly straightforward, and could probably > be taken as-is. Patch 9 is a rewrite of v8 4/17, but in the opposite > direction (document that no sorting is done, rather than attempting > to sort), so it may need further fine-tuning. Patches 12-21 > represents a fusion of Markus' and my attempts to rewrite v5 7/17 > into a more-reviewable set of patches, and caused further churn > later in the series. Hard freeze is next week. PATCH 01-07+09 are simple cleanups, bug fixes tests and documentation, which makes them obvious candidates for 2.5. PATCH 08 is a feature, but harmless enough. I still don't like it much, but I said I'll take it. Best before the hard freeze, though. The remainder of the series doesn't feel like post hard freeze material. What do you think? I don't have the complete picture of your queue. Please double-check whether you got anything in it that affects introspection, because changing introspection will become super awkward as soon as 2.5 is out. > Patch 23 still uses tag_member.type == None; I ran out of time to > work on Markus' idea of providing an instance of QAPISchemaBuiltinType > to fill the role for 'qtype_code' without being exposed through .json > files and without breaking the invariant of a valid member.type after > check(), and wanted to get the rest of the series started under revew. > So I may need a followup patch or even a v10 of the later half of > this series after exploring that idea more. I'll continue reviewing meanwhile.