From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Daniel Vetter" <daniel@ffwll.ch>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 2/2] drm/i915: shut up gen8+ SDE irq dmesg noise
Date: Tue, 27 Oct 2015 10:10:38 +0200 [thread overview]
Message-ID: <87bnbkviip.fsf@intel.com> (raw)
In-Reply-To: <CAKMK7uGhoEeL8sxKuai+wFTxCCYYf-B5VUSPEPLtii4a9bj6vA@mail.gmail.com>
On Tue, 27 Oct 2015, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, Oct 23, 2015 at 8:22 AM, Ville Syrjälä
> <ville.syrjala@linux.intel.com> wrote:
>> The regressing patch change didn't add the message, so there was a clear
>> change in behaviour, and now it's papered over.
>
> It did move around the DRM_ERROR for all the others and also added the
> SDE one for consistency. At least that's how I read that patch - I
> could't find the SDE DRM_ERROR in the old code. Did I miss something?
Yes. We tried and failed to point out that this is a bisected regression
with a bug report. The bad commit is *NOT* when the error message was
added or moved. The first bad commit is
commit aaf5ec2e51ab1d9c5e962b4728a1107ed3ff7a3e
Author: Sonika Jindal <sonika.jindal@intel.com>
Date: Wed Jul 8 17:07:47 2015 +0530
drm/i915: Handle HPD when it has actually occurred
which triggers printing of the error message. This is all mentioned in
the bug, along with a few attempts at remedying the situation.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-10-27 8:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 8:56 [PATCH 1/2] drm/i915: Shut up GuC errors when it's disabled Daniel Vetter
2015-10-23 8:56 ` [PATCH 2/2] drm/i915: shut up gen8+ SDE irq dmesg noise Daniel Vetter
2015-10-23 9:03 ` Chris Wilson
2015-10-23 9:14 ` Daniel Vetter
2015-10-23 14:21 ` Dave Gordon
2015-10-23 9:21 ` Jani Nikula
2015-10-23 9:23 ` Daniel Vetter
2015-10-23 13:33 ` Ville Syrjälä
2015-10-23 13:40 ` Chris Wilson
2015-10-23 13:47 ` Ville Syrjälä
2015-10-23 14:42 ` Daniel Vetter
2015-10-23 15:22 ` Ville Syrjälä
2015-10-27 2:31 ` Daniel Vetter
2015-10-27 8:10 ` Jani Nikula [this message]
2015-10-28 0:22 ` Daniel Vetter
2015-10-23 9:00 ` [PATCH] drm/i915: Don't complain about lack of ACPI video bios Daniel Vetter
2015-10-23 11:46 ` Jani Nikula
2015-10-23 9:10 ` [PATCH] drm/i915: Shut up GuC errors when it's disabled Daniel Vetter
2015-10-23 10:56 ` Mika Kuoppala
2015-10-23 11:32 ` Daniel Vetter
2015-10-23 9:21 ` [PATCH 1/2] " kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bnbkviip.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=daniel.vetter@intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.