From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60988)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZpITy-0002qT-Ge
	for qemu-devel@nongnu.org; Thu, 22 Oct 2015 12:12:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZpITv-0007I6-BR
	for qemu-devel@nongnu.org; Thu, 22 Oct 2015 12:12:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46690)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZpITv-0007I1-6l
	for qemu-devel@nongnu.org; Thu, 22 Oct 2015 12:12:47 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1445056549-7815-1-git-send-email-eblake@redhat.com>
	<1445056549-7815-4-git-send-email-eblake@redhat.com>
Date: Thu, 22 Oct 2015 18:12:44 +0200
In-Reply-To: <1445056549-7815-4-git-send-email-eblake@redhat.com> (Eric
	Blake's message of "Fri, 16 Oct 2015 22:35:38 -0600")
Message-ID: <87bnbqubk3.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v7 03/14] qapi: Provide nicer array names
	in introspection
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>

Eric Blake <eblake@redhat.com> writes:

> For the sake of humans reading introspection output, it is nice
> to have the name of implicit array types be recognizable as
> arrays of the underlying type.  However, while this patch allows
> humans to skip from a command with return type "[123]" straight
> to the definition of type "123" without having to first inspect
> type "[123]", document that this shortcut should not be taken by
> client apps.

Personally, I still don't see much value in special-casing array names.
On the other hand, the patch is really simple.

> This makes the resulting introspection string slightly larger by
> default, but slightly smaller when -u is in use (as '[FOO]' is
> nicer than 'FOOList' for expressing 'array of FOO').

Size with -u is unimportant.

If we don't want to pay the prize in size without -u, we can make it
conditional on -u.  But with -u, [FOO] isn't much of an improvement over
FooList.

Anyway, if you want the feature, I'll take the patch.