From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from sabertooth01.qualcomm.com ([65.197.215.72]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZoW36-0002St-7y for ath10k@lists.infradead.org; Tue, 20 Oct 2015 12:29:52 +0000 From: Kalle Valo Subject: Re: [PATCH 1/5] ath10k: QCA988X hw2.0: add board.bin References: <1444905644-16296-1-git-send-email-kvalo@qca.qualcomm.com> <1445192636.31451.74.camel@decadent.org.uk> <1445193116.31451.78.camel@decadent.org.uk> Date: Tue, 20 Oct 2015 15:29:13 +0300 In-Reply-To: <1445193116.31451.78.camel@decadent.org.uk> (Ben Hutchings's message of "Sun, 18 Oct 2015 19:31:56 +0100") Message-ID: <87bnbtd8py.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Ben Hutchings Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, linux-firmware@kernel.org QmVuIEh1dGNoaW5ncyA8YmVuQGRlY2FkZW50Lm9yZy51az4gd3JpdGVzOgoKPiBPbiBTdW4sIDIw MTUtMTAtMTggYXQgMTk6MjMgKzAxMDAsIEJlbiBIdXRjaGluZ3Mgd3JvdGU6Cj4+IE9uIFRodSwg MjAxNS0xMC0xNSBhdCAxMzo0MCArMDMwMCwgS2FsbGUgVmFsbyB3cm90ZToKPj4gPiBJbiBjb21t aXQgNDBkMTQxNDNiNzg3ICgiYXRoMTBrOiBhZGQgZmlybXdhcmUgMTAuMi40LjQ1IGFzIGZpcm13 YXJlLTQuYmluIikgSQo+PiA+IGZvcmdvdCB0byBjb21taXQgYm9hcmQuYmluIGZpbGUgYW5kIHRo YXQncyB3aHkgaXQgd2FzIG5vdCBpbmNsdWRlZCBpbiB0aGUKPj4gPiBjb21taXQgZXZlbiBJIGhh ZCBhZGRlZCBhbiBlbnRyeSB0byBXSEVOQ0UuIEFkZCB0aGF0IG5vdy4KPj4gPiAKPj4gPiBBdCB0 aGUgc2FtZSB0aW1lIGFsc28gYWRkIFZlcnNpb24gZmllbGQgZm9yIGZpcm13YXJlLTQuYmluLgo+ PiA+IAo+PiA+IFNpZ25lZC1vZmYtYnk6IEthbGxlIFZhbG8gPGt2YWxvQHFjYS5xdWFsY29tbS5j b20+Cj4+IFsuLi5dCj4+IAo+PiBJJ3ZlIGFwcGxpZWQgdGhpcyBhbmQgdGhlIGZvbGxvd2luZyA0 IHBhdGNoZXMuIMKgSG93ZXZlciwgSSdtIG5vdAo+PiBlbnRpcmVseSBoYXBweSB3aXRoIGNvcHly aWdodCBhY2tub3dsZWRnZW1lbnRzIGdvaW5nIGludG8gdGhlCj4+IG5vdGljZV9hdGgxMGsqLnR4 dCBmaWxlcyB3aGljaCBhcmVuJ3QgcmVmZXJlbmNlZCBhbnl3aGVyZS4gwqBJdCB3b3VsZCBiZQo+ PiBlYXN5IGZvciBkb3duc3RyZWFtIGRpc3RyaWJ1dG9ycyB0byBtaXNzIHRoYXQgdGhleSBzaG91 bGQgYmUgcGFja2FnZWQKPj4gYWxvbmcgd2l0aCB0aGUgZmlybXdhcmUgYmxvYnMgdGhleSByZWxh dGUgdG8uIMKgUGxlYXNlIGNhbiB5b3UgY29tYmluZQo+PiB0aGVzZSB3aXRoIHRoZSBRQ0EgbGlj ZW5jZSBmaWxlIG9yIGFkZCByZWZlcmVuY2VzIHRvIHRoZXNlIGZpbGVzIGZyb20KPj4gV0hFTkNF Pwo+PiAKPgo+IEFsc28gcGxlYXNlIG1ha2Ugc3VyZSB0aGF0IGFsbCB0ZXh0IGZpbGVzIGFyZSBl bmNvZGVkIGFzIFVURi04IChvcgo+IEFTQ0lJKS4gwqBBIGNvdXBsZSBvZiB0aGUgbm90aWNlcyBo YWQgcXVvdGUgY2hhcmFjdGVycyB3aGljaCBJCj4gZXZlbnR1YWxseSB3b3JrZWQgb3V0IHRvIGJl IEdCMjMxMi1lbmNvZGVkLgoKU29ycnkgYWJvdXQgdGhhdCwgSSdsbCBjaGVjayBmb3IgdGhhdCBp biB0aGUgZnV0dXJlLgoKLS0gCkthbGxlIFZhbG8KCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmF0aDEwayBtYWlsaW5nIGxpc3QKYXRoMTBrQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9h dGgxMGsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from sabertooth01.qualcomm.com ([65.197.215.72]:54076 "EHLO sabertooth01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751832AbbJTM3b convert rfc822-to-8bit (ORCPT ); Tue, 20 Oct 2015 08:29:31 -0400 From: Kalle Valo To: Ben Hutchings CC: , , Subject: Re: [PATCH 1/5] ath10k: QCA988X hw2.0: add board.bin References: <1444905644-16296-1-git-send-email-kvalo@qca.qualcomm.com> <1445192636.31451.74.camel@decadent.org.uk> <1445193116.31451.78.camel@decadent.org.uk> Date: Tue, 20 Oct 2015 15:29:13 +0300 In-Reply-To: <1445193116.31451.78.camel@decadent.org.uk> (Ben Hutchings's message of "Sun, 18 Oct 2015 19:31:56 +0100") Message-ID: <87bnbtd8py.fsf@kamboji.qca.qualcomm.com> (sfid-20151020_142935_032649_7B3848CA) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Sender: linux-wireless-owner@vger.kernel.org List-ID: Ben Hutchings writes: > On Sun, 2015-10-18 at 19:23 +0100, Ben Hutchings wrote: >> On Thu, 2015-10-15 at 13:40 +0300, Kalle Valo wrote: >> > In commit 40d14143b787 ("ath10k: add firmware 10.2.4.45 as firmware-4.bin") I >> > forgot to commit board.bin file and that's why it was not included in the >> > commit even I had added an entry to WHENCE. Add that now. >> > >> > At the same time also add Version field for firmware-4.bin. >> > >> > Signed-off-by: Kalle Valo >> [...] >> >> I've applied this and the following 4 patches.  However, I'm not >> entirely happy with copyright acknowledgements going into the >> notice_ath10k*.txt files which aren't referenced anywhere.  It would be >> easy for downstream distributors to miss that they should be packaged >> along with the firmware blobs they relate to.  Please can you combine >> these with the QCA licence file or add references to these files from >> WHENCE? >> > > Also please make sure that all text files are encoded as UTF-8 (or > ASCII).  A couple of the notices had quote characters which I > eventually worked out to be GB2312-encoded. Sorry about that, I'll check for that in the future. -- Kalle Valo