Re: [PATCH] btrfs: compress: put variables defined per compress type in struct to make cache friendly

[Byongho Lee <bhlee.kernel@gmail.com>]

David Sterba writes:

>
>> +static struct {
>> +	struct list_head idle_workspace;
>> +	spinlock_t workspace_lock;
>> +	int num_workspace;
>> +	atomic_t alloc_workspace;
>> +	wait_queue_head_t workspace_wait;
>> +} comp[BTRFS_COMPRESS_TYPES];
>
> The name became too generic, please rename it to btrfs_comp_ws.
> btrfs_comp_workspaces would be too long. I won't mind trimming the
> members to 'ws' instead of 'workspace' so this does not result in too
> wild code formatting. The use of the workspaces is localized only to the
> compression code so it will not be confusing.

Thanks for feedback.
I will prepare v2 patch applying your comment.