From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51829) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAzBC-0007Ch-42 for qemu-devel@nongnu.org; Fri, 03 Jul 2015 07:30:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZAzB8-0000Pb-3d for qemu-devel@nongnu.org; Fri, 03 Jul 2015 07:30:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58072) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAzB7-0000PX-Sv for qemu-devel@nongnu.org; Fri, 03 Jul 2015 07:30:46 -0400 From: Markus Armbruster References: <1435161381-31521-1-git-send-email-thuth@redhat.com> <20150626094159.GF15457@stefanha-thinkpad.redhat.com> Date: Fri, 03 Jul 2015 13:30:43 +0200 In-Reply-To: <20150626094159.GF15457@stefanha-thinkpad.redhat.com> (Stefan Hajnoczi's message of "Fri, 26 Jun 2015 10:41:59 +0100") Message-ID: <87bnftbhr0.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 0/5] Network traffic dumping for -netdev, second try List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Thomas Huth , Jason Wang , Stefan Hajnoczi , qemu-devel@nongnu.org Stefan Hajnoczi writes: > On Wed, Jun 24, 2015 at 05:56:16PM +0200, Thomas Huth wrote: >> The "-net dump" option only works with the "-net" option. So far, it >> is not possible to dump network traffic with the "-netdev" option yet. >> This patch series now fixes this ugliness by enabling dumping for the >> "-netdev" option, too. >> >> Unlike with my first attempt a couple of weeks ago ("net: Enable vlans >> and dump for -netdev, too"), this patch series now does not "abuse" >> the disliked internal vlan hub infrastructure anymore but introduces >> a new, clean "dumpfile=xxx" option for the -netdev parameters instead. >> >> It's likely too late for version 2.4 for this patch series, but it >> would be great to get some review feedback for this anyway. >> >> Thomas Huth (5): >> net/dump: Add support for receive_iov function >> net/dump: Move DumpState into NetClientState >> net/dump: Rework net-dump init functions >> net/dump: Add dump option for netdev devices >> qemu options: Add information about dumpfile to help text >> >> include/net/net.h | 8 +++++ >> net/clients.h | 5 ++++ >> net/dump.c | 89 ++++++++++++++++++++++++++++++++++++------------------- >> net/net.c | 48 ++++++++++++++++++++++++++++++ >> qapi-schema.json | 12 ++++++-- >> qemu-options.hx | 26 +++++++++++----- >> 6 files changed, 147 insertions(+), 41 deletions(-) > > Overall this approach looks good, let's do it in QEMU 2.5. Seconded.