All of lore.kernel.org
 help / color / mirror / Atom feed
From: bjorn@mork.no (Bjørn Mork)
To: kernelnewbies@lists.kernelnewbies.org
Subject: why is "const u32 (*tab)[256]" not kerneldoc-able?
Date: Tue, 03 Feb 2015 14:38:13 +0100	[thread overview]
Message-ID: <87bnlbuncq.fsf@nemi.mork.no> (raw)
In-Reply-To: <87fvanuo9h.fsf@nemi.mork.no> ("Bjørn Mork"'s message of "Tue, 03 Feb 2015 14:18:34 +0100")

Bj?rn Mork <bjorn@mork.no> writes:

> Maybe the attached simple patch is good enough?  Completely untested
> except for a single run against that file....

Ah, umh, no.  That "const u32 (*)[256] tab" does not look correct:


crc32_le_generic(9)                                   Kernel Hacker's Manual                                  crc32_le_generic(9)

NAME
       crc32_le_generic - Calculate bitwise little-endian Ethernet AUTODIN II CRC32/CRC32C

SYNOPSIS
       u32 __pure crc32_le_generic (u32 crc, unsigned char const *p, size_t len, const u32 (*)[256] tab, u32 polynomial);

ARGUMENTS
       crc         seed  value  for computation.  ~0 for Ethernet, sometimes 0 for other uses, or the previous crc32/crc32c value
                   if computing incrementally.

       p           pointer to buffer over which CRC32/CRC32C is run

       len         length of buffer p

       tab         little-endian Ethernet table

       polynomial  CRC32/CRC32c LE polynomial



I guess a proper fix is needed.



Bj?rn

  parent reply	other threads:[~2015-02-03 13:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-03 12:19 why is "const u32 (*tab)[256]" not kerneldoc-able? Robert P. J. Day
2015-02-03 13:15 ` Malte Vesper
2015-02-03 14:09   ` Robert P. J. Day
2015-02-03 13:18 ` Bjørn Mork
2015-02-03 13:36   ` Robert P. J. Day
2015-02-03 13:38   ` Bjørn Mork [this message]
2015-02-03 13:44     ` Robert P. J. Day
2015-02-03 14:46       ` Bjørn Mork
2015-02-03 14:50         ` Robert P. J. Day

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bnlbuncq.fsf@nemi.mork.no \
    --to=bjorn@mork.no \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.