All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries
Date: Wed, 07 Jan 2015 20:05:00 +0200	[thread overview]
Message-ID: <87bnmapiur.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1419685980-4728-1-git-send-email-arend@broadcom.com> (Arend van Spriel's message of "Sat, 27 Dec 2014 14:13:00 +0100")

Arend van Spriel <arend@broadcom.com> writes:

> Use the helper to get rid of the file operations per debugfs file. The
> device driver data contains struct ieee80211_hw pointer and the
> struct ath9k_softc pointer is assigned to ieee80211_hw::priv so it can
> be accessed in the seq_file read operation.
>
> Cc: ath9k-devel at lists.ath9k.org
> Signed-off-by: Arend van Spriel <arend@broadcom.com>
> ---
> Hi Kalle,
>
> This patch was reverted in the driver-core repository as I overlooked
> the use of driver data and caused ath9k driver to crash. I believe this
> revised patch properly uses it now although I have no ath9k hardware to
> test this. So I hope some ath9k developers out there can give this patch
> a run for its money. It compiles and no checkpatch or sparse warnings.
>
> The patch applies to the master branch of the wireless-drivers-next
> repository.

Can someone with ath9k hardware test this, please? I'm hesitant to apply
this without testing.

-- 
Kalle Valo

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Arend van Spriel <arend@broadcom.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	<ath9k-devel@lists.ath9k.org>
Subject: Re: [PATCH] ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries
Date: Wed, 07 Jan 2015 20:05:00 +0200	[thread overview]
Message-ID: <87bnmapiur.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1419685980-4728-1-git-send-email-arend@broadcom.com> (Arend van Spriel's message of "Sat, 27 Dec 2014 14:13:00 +0100")

Arend van Spriel <arend@broadcom.com> writes:

> Use the helper to get rid of the file operations per debugfs file. The
> device driver data contains struct ieee80211_hw pointer and the
> struct ath9k_softc pointer is assigned to ieee80211_hw::priv so it can
> be accessed in the seq_file read operation.
>
> Cc: ath9k-devel@lists.ath9k.org
> Signed-off-by: Arend van Spriel <arend@broadcom.com>
> ---
> Hi Kalle,
>
> This patch was reverted in the driver-core repository as I overlooked
> the use of driver data and caused ath9k driver to crash. I believe this
> revised patch properly uses it now although I have no ath9k hardware to
> test this. So I hope some ath9k developers out there can give this patch
> a run for its money. It compiles and no checkpatch or sparse warnings.
>
> The patch applies to the master branch of the wireless-drivers-next
> repository.

Can someone with ath9k hardware test this, please? I'm hesitant to apply
this without testing.

-- 
Kalle Valo

  reply	other threads:[~2015-01-07 18:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-27 13:13 [ath9k-devel] [PATCH] ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries Arend van Spriel
2014-12-27 13:13 ` Arend van Spriel
2015-01-07 18:05 ` Kalle Valo [this message]
2015-01-07 18:05   ` Kalle Valo
2015-01-08  3:19   ` [ath9k-devel] " Sujith Manoharan
2015-01-08  3:19     ` Sujith Manoharan
2015-01-08 20:10     ` [ath9k-devel] " Arend van Spriel
2015-01-08 20:10       ` Arend van Spriel
2015-01-09  0:34       ` [ath9k-devel] " Sujith Manoharan
2015-01-09  0:34         ` Sujith Manoharan
2015-01-09  9:59         ` [ath9k-devel] " Arend van Spriel
2015-01-09  9:59           ` Arend van Spriel
2015-01-15 12:39 ` [ath9k-devel] " Kalle Valo
2015-01-15 12:39   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bnmapiur.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.