Re: [PATCHv1 1/7] dt-bindings: use isil prefix for Intersil

[arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org (Arnaud Ebalard)]

Hello Uwe,

Uwe Kleine-König <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> writes:

> On Tue, Dec 16, 2014 at 01:22:27AM +0100, Arnaud Ebalard wrote:
>> This patch fixes DT documentation to reference isil (NASDAQ symbol and
>> the most used prefix inside the kernel) for all Intersil products.
>> 
>> It reverts both 7c75c1d5e72b ("dt-bindings: Document deprecated device
>> vendor name to fix related warning") and b2ea3f82e798 ("dt-bindings:
>> Document correct and deprecated vendor-prefix with device isl29028").
> Unrelated to this patch I wonder if checkpatch could be improved to not
> warn about unknown vendor prefixes in compatibility strings that only
> exist for compatibility. This assumes that it's not necessary to also
> document deprecated vendor prefixes, not sure about this
> one. Thoughts?

AFAICT, we want checkpatch to detect mistakes in patches which are about
to be merged. I think checkpatch will work as expected for those new
patches, i.e. warn someone if she tries and use an unknown vendor prefix
or a deprecated one ... as long as deprecated prefixes are not in
vendor-prefixes.txt. IMHO, that's the reason it is a bad idea to put
deprecated prefixes in vendor-prefixes.txt, it make checkpatch silent
about the use of a deprecated prefix.

For existing files, I think checkpatch can be useful in order to do the
work I did in this series (for Intersil) for unknown vendors. A quick
run gives a value of 237 vendors prefix issues on the 527 arm .dts
files ;-)


>> Signed-off-by: Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>
>> ---
>>  Documentation/devicetree/bindings/i2c/trivial-devices.txt | 5 ++---
>>  Documentation/devicetree/bindings/vendor-prefixes.txt     | 3 +--
> I guess it's OK to keep the two changes in one patch, but formally they
> are maintained by different people. Should this patch be split?

I'll send a new batch for the space issue you point below. I will take
take the opportunity to split those.


>>  2 files changed, 3 insertions(+), 5 deletions(-)
>> 
>> diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
>> index 9f4e3824e71e..0aaff72065bf 100644
>> --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
>> +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
>> @@ -58,9 +58,8 @@ fsl,sgtl5000		SGTL5000: Ultra Low-Power Audio Codec
>>  gmt,g751		G751: Digital Temperature Sensor and Thermal Watchdog with Two-Wire Interface
>>  infineon,slb9635tt	Infineon SLB9635 (Soft-) I2C TPM (old protocol, max 100khz)
>>  infineon,slb9645tt	Infineon SLB9645 I2C TPM (new protocol, max 400khz)
>> -isl,isl12057		Intersil ISL12057 I2C RTC Chip
>> -isil,isl29028           (deprecated, use isl)
>> -isl,isl29028            Intersil ISL29028 Ambient Light and Proximity Sensor
>> +isil,isl12057		Intersil ISL12057 I2C RTC Chip
>> +isil,isl29028           Intersil ISL29028 Ambient Light and Proximity Sensor
> Here is some tab vs space issue. The surrounding lines (in the context)
> all use tab.

will tabify those.


>>  maxim,ds1050		5 Bit Programmable, Pulse-Width Modulator
>>  maxim,max1237		Low-Power, 4-/12-Channel, 2-Wire Serial, 12-Bit ADCs
>>  maxim,max6625		9-Bit/12-Bit Temperature Sensors with I²C-Compatible Serial Interface
>
> Best regards
> Uwe