From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Arend van Spriel <arend@broadcom.com>
Cc: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>,
"John W . Linville" <linville@tuxdriver.com>,
<linux-wireless@vger.kernel.org>, <wil6210@qca.qualcomm.com>
Subject: Re: [PATCH 2/2] wil6210: atomic I/O for the card memory
Date: Fri, 14 Nov 2014 16:54:33 +0200 [thread overview]
Message-ID: <87bno9suhi.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <5466125A.7090001@broadcom.com> (Arend van Spriel's message of "Fri, 14 Nov 2014 15:31:54 +0100")
Arend van Spriel <arend@broadcom.com> writes:
> On 11/14/14 14:29, Kalle Valo wrote:
>> Vladimir Kondratiev<qca_vkondrat@qca.qualcomm.com> writes:
>>
>>> Introduce netdev IOCTLs, to be used by the debug tools.
>>>
>>> Allows to read/write single dword value or
>>> memory block, aligned to dword
>>> Different address modes supported:
>>> - BAR offset
>>> - Firmware "linker" address
>>> - target's AHB bus
>>>
>>> Signed-off-by: Vladimir Kondratiev<qca_vkondrat@qca.qualcomm.com>
>>
>> An ioctl interface for a wireless driver? IMHO that would have been ok
>> in 2004, but not in 2014. Isn't there really better way to implement
>> this?
>
> If this is really driver/device specific debug tool stuff, you should
> probably consider the vendor commands through nl80211 API.
Yeah, that's one way to do it. In ath6kl we used debugfs for this, but
no idea which one is better.
--
Kalle Valo
next prev parent reply other threads:[~2014-11-14 14:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 12:05 [PATCH 0/2] wil6210 patches Vladimir Kondratiev
2014-10-01 12:05 ` [PATCH 1/2] wil6210: manual FW error recovery mode Vladimir Kondratiev
2014-10-01 12:05 ` [PATCH 2/2] wil6210: atomic I/O for the card memory Vladimir Kondratiev
2014-11-14 13:29 ` Kalle Valo
2014-11-14 14:31 ` Arend van Spriel
2014-11-14 14:54 ` Kalle Valo [this message]
2014-11-16 8:55 ` Vladimir Kondratiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bno9suhi.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=arend@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=qca_vkondrat@qca.qualcomm.com \
--cc=wil6210@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.