All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] docs/manual: remove example comment causing issues
Date: Sun, 12 Oct 2014 16:18:15 +0200	[thread overview]
Message-ID: <87bnphxtg8.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1413120085-21063-1-git-send-email-thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Sun, 12 Oct 2014 15:21:25 +0200")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > The manual gives this example for using the github macro:
 >   FOO_VERSION = v1.0 # tag or full commit ID

 > Unfortunately, people copy/pasting this example will face weird make
 > errors, because it leads the FOO_VERSION variable to end with a
 > space. Since the manual is anyway explaining just below the example
 > that FOO_VERSION can be used either with a tag or a full commit ID,
 > the simplest solution is to simply remove this comment.

 > Reported-by: Edd Robbins <edd.robbins@gmail.com>
 > Cc: Edd Robbins <edd.robbins@gmail.com>
 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Thanks, but I'll rather just fix the issue instead as people can very
easily end up with something like this when E.G. testing a version bump.

-- 
Bye, Peter Korsgaard

      parent reply	other threads:[~2014-10-12 14:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-12 13:21 [Buildroot] [PATCH] docs/manual: remove example comment causing issues Thomas Petazzoni
2014-10-12 13:44 ` Yann E. MORIN
2014-10-12 14:18 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bnphxtg8.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.