From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53428)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XYVhC-0003xr-RU
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 03:48:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XYVh8-0006r5-1A
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 03:48:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:30383)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XYVh7-0006hH-Pd
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 03:48:29 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1411108984-4380-1-git-send-email-zhang.zhanghailiang@huawei.com>
	<1411108984-4380-2-git-send-email-zhang.zhanghailiang@huawei.com>
Date: Mon, 29 Sep 2014 09:48:17 +0200
In-Reply-To: <1411108984-4380-2-git-send-email-zhang.zhanghailiang@huawei.com>
	(zhanghailiang's message of "Fri, 19 Sep 2014 14:43:03 +0800")
Message-ID: <87bnpyvpdq.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v6 1/2] dump: let dump_error return error
	info to caller
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>
Cc: lersek@redhat.com, lcapitulino@redhat.com, luonengjun@huawei.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com

zhanghailiang <zhang.zhanghailiang@huawei.com> writes:

> The second parameter of dump_error is unused, but one purpose of
> using this function is to report the error info.
>
> Use error_set to return the error info to the caller.
>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>

The commit message doesn't explain this patch's benefit clearly.
Suggest:

    dump: Propagate errors into qmp_dump_guest_memory()

    The code calls dump_error() on error, and even passes it a suitable
    message.  However, the message is thrown away, and its callers pass
    up only success/failure.  All qmp_dump_guest_memory() can do is set
    a generic error.

    Propagate the errors properly, so qmp_dump_guest_memory() can return
    a more useful error.

With a commit message like that:

Reviewed-by: Markus Armbruster <armbru@redhat.com>