From: Juan Quintela <quintela@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Orit Wasserman <owasserm@redhat.com>,
qemu-devel@nongnu.org, anthony@codemonkey.ws
Subject: Re: [Qemu-devel] [PATCH 7/8] Don't abort on memory allocation error
Date: Tue, 04 Feb 2014 21:07:20 +0100 [thread overview]
Message-ID: <87bnymiqvb.fsf@elfo.mitica> (raw)
In-Reply-To: <20140204173404.GE2733@work-vm> (David Alan Gilbert's message of "Tue, 4 Feb 2014 17:34:05 +0000")
"Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote:
> * Juan Quintela (quintela@redhat.com) wrote:
>> From: Orit Wasserman <owasserm@redhat.com>
>
>> if (!it->it_data) {
>> cache->num_items++;
>> + it->it_data = g_try_malloc(cache->page_size);
>> + if (!it->it_data) {
>> + DPRINTF("Error allocating page\n");
>> + return -1;
>> + }
>
> Hmm that wasn't the latest version of that patch (or the previous
> one in the series).
Error on my part, already Nacked and sent a new version.
Later, Juan.
next prev parent reply other threads:[~2014-02-04 20:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 15:19 [Qemu-devel] [PULL 0/8] migration queue Juan Quintela
2014-02-04 15:19 ` [Qemu-devel] [PATCH 1/8] vmstate: Make VMSTATE_STRUCT_POINTER take type, not ptr-to-type Juan Quintela
2014-02-04 15:19 ` [Qemu-devel] [PATCH 2/8] Set xbzrle buffers to NULL after freeing them to avoid double free errors Juan Quintela
2014-02-04 15:19 ` [Qemu-devel] [PATCH 3/8] Add check for cache size smaller than page size Juan Quintela
2014-02-04 15:19 ` [Qemu-devel] [PATCH 4/8] migration:fix free XBZRLE decoded_buf wrong Juan Quintela
2014-02-04 15:19 ` [Qemu-devel] [PATCH 5/8] XBZRLE cache size should not be larger than guest memory size Juan Quintela
2014-02-04 16:26 ` Eric Blake
2014-02-04 16:29 ` Orit Wasserman
2014-02-04 15:19 ` [Qemu-devel] [PATCH 6/8] Don't abort on out of memory when creating page cache Juan Quintela
2014-02-04 15:19 ` [Qemu-devel] [PATCH 7/8] Don't abort on memory allocation error Juan Quintela
2014-02-04 17:34 ` Dr. David Alan Gilbert
2014-02-04 20:07 ` Juan Quintela [this message]
2014-02-04 15:19 ` [Qemu-devel] [PATCH 8/8] exec: fix ram_list dirty map optimization Juan Quintela
2014-02-04 15:54 ` [Qemu-devel] [PULL 0/8] migration queue Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bnymiqvb.fsf@elfo.mitica \
--to=quintela@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=dgilbert@redhat.com \
--cc=owasserm@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.