From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46486)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1W5DRj-00071o-SQ
	for qemu-devel@nongnu.org; Mon, 20 Jan 2014 06:55:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1W5DRd-0004xR-SF
	for qemu-devel@nongnu.org; Mon, 20 Jan 2014 06:55:15 -0500
Received: from mx1.redhat.com ([209.132.183.28]:60670)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1W5DRd-0004xG-Ka
	for qemu-devel@nongnu.org; Mon, 20 Jan 2014 06:55:09 -0500
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0KBt80Z006400
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 20 Jan 2014 06:55:08 -0500
From: Markus Armbruster <armbru@redhat.com>
References: <1390214659-12296-1-git-send-email-alevy@redhat.com>
Date: Mon, 20 Jan 2014 12:55:05 +0100
In-Reply-To: <1390214659-12296-1-git-send-email-alevy@redhat.com> (Alon Levy's
	message of "Mon, 20 Jan 2014 12:44:18 +0200")
Message-ID: <87bnz627hi.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 1/2] hw/display/qxl: improve framebuffer
	error message
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org, kraxel@redhat.com

Alon Levy <alevy@redhat.com> writes:

> Signed-off-by: Alon Levy <alevy@redhat.com>
> ---
>  hw/display/qxl.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/display/qxl.c b/hw/display/qxl.c
> index e4f172e..f6af470 100644
> --- a/hw/display/qxl.c
> +++ b/hw/display/qxl.c
> @@ -1367,7 +1367,8 @@ static void qxl_create_guest_primary(PCIQXLDevice *qxl, int loadvm,
>      size = abs(requested_stride) * requested_height;
>      if (size > qxl->vgamem_size) {
>          qxl_set_guest_bug(qxl, "%s: requested primary larger then framebuffer"
> -                               " size", __func__);
> +                               " size %d > %d", __func__, size,
> +                               qxl->vgamem_size);
>          return;
>      }

Shouldn't you use %u or %PRIu32 to print uint32_t qxl->vgamem_size?

Hmm, we're comparing int size to uint32_t vgamem_size, not nice.  Should
size be unsigned?

Since you touch the message anyway, you could fix "larger then" to
"larger than".