From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58325)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1Vr4fr-0003Xx-6h
	for qemu-devel@nongnu.org; Thu, 12 Dec 2013 06:43:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1Vr4fj-0003za-Tv
	for qemu-devel@nongnu.org; Thu, 12 Dec 2013 06:43:23 -0500
Received: from static.88-198-71-155.clients.your-server.de
	([88.198.71.155]:51776 helo=socrates.bennee.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1Vr4fj-0003zG-Ns
	for qemu-devel@nongnu.org; Thu, 12 Dec 2013 06:43:15 -0500
References: <1386799315-4431-1-git-send-email-peter.maydell@linaro.org>
	<1386799315-4431-2-git-send-email-peter.maydell@linaro.org>
	<CAOVdOBGdZAxpjsoXk_UFyrB8-Lk_BXss1_9VqncThV5BJ5m7JA@mail.gmail.com>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <CAOVdOBGdZAxpjsoXk_UFyrB8-Lk_BXss1_9VqncThV5BJ5m7JA@mail.gmail.com>
Date: Thu, 12 Dec 2013 11:43:10 +0000
Message-ID: <87bo0m5m7l.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v2 1/8] target-arm: A64: add support for
	ld/st pair
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: C Fontana <claudio.fontana@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>, Patch Tracking <patches@linaro.org>, Michael Matz <matz@suse.de>, QEMU Developers <qemu-devel@nongnu.org>, Will Newton <will.newton@linaro.org>, Dirk Mueller <dmueller@suse.de>, Laurent Desnogues <laurent.desnogues@gmail.com>, "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>, Christoffer Dall <christoffer.dall@linaro.org>, Richard Henderson <rth@twiddle.net>


claudio.fontana@linaro.org writes:

> Hi,
>
> I saw a missing return below:
<snip>
>> +    default: /* Failed decoder tree? */
>> +        unallocated_encoding(s);
>> +        break;
>> +    }
>
> This doesn't seem right (break instead of return):
>
> default:
>     unallocated_encoding(s);
>     return;
> }

Good catch. I suspect it never hits though (or risu doesn't generate
enough unallocated versions).

-- 
Alex Bennée
QEMU/KVM Hacker for Linaro