All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Joe Perches <joe@perches.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [trivial PATCH] module.h: Remove unnecessary semicolon
Date: Fri, 08 Nov 2013 11:56:12 +1030	[thread overview]
Message-ID: <87bo1v4rbf.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1383868777.9263.39.camel@joe-AO722>

Joe Perches <joe@perches.com> writes:
> On Fri, 2013-11-08 at 09:41 +1030, Rusty Russell wrote:
>> Joe Perches <joe@perches.com> writes:
>> > That's a trust issue.
>> > I've done it.  It isn't necessary.
>> 
>> WTF?  Now you just said it's not necessary, I *know* I can't trust you.
>
> "It" in this case is the grep that I did
> prior to sending the patch.

Hi Joe,

Apologies for my off tone.  But I think we got tangled somewhere?

You said "It isn't necessary".

You maintain that grepping the source to find out if you'd broken
something "isn't necessary"?

git history shows me you've done lots of these cleanups.  I'm pretty
sure that's not what you meant.

But as maintainer, it's annoying that I had to check myself.  I don't
have personal experience in how diligent you are.  If you'd just
mentioned it, it would have saved me a few minutes and streamlined my
workflow immensely. 

Providing assurance makes me a happy maintainer.  So I modified it
because it sets a clear example for others.

I hope that clarifies,
Rusty.

  reply	other threads:[~2013-11-08  1:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-05 20:58 [trivial PATCH] module.h: Remove unnecessary semicolon Joe Perches
2013-11-07  2:02 ` Rusty Russell
2013-11-07  5:09   ` Joe Perches
2013-11-07 23:11     ` Rusty Russell
2013-11-07 23:59       ` Joe Perches
2013-11-08  1:26         ` Rusty Russell [this message]
2013-11-08  1:48           ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bo1v4rbf.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.