From: Rusty Russell <rusty@rustcorp.com.au>
To: James Hogan <james.hogan@imgtec.com>, linux-kernel@vger.kernel.org
Cc: James Hogan <james.hogan@imgtec.com>
Subject: Re: [PATCH] metag: move EXPORT_SYMBOLs in libs to metag_ksyms.c
Date: Wed, 03 Jul 2013 10:15:53 +0930 [thread overview]
Message-ID: <87bo6kfp32.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1372774074-18553-1-git-send-email-james.hogan@imgtec.com>
James Hogan <james.hogan@imgtec.com> writes:
> Move all EXPORT_SYMBOLs in libs-y directories (arch/metag/{lib,tbx})
> into metag_ksyms.c so that they don't get omitted by the static linker
> if they're not used by any other statically linked code, which can
> result in undefined symbols when building modules.
>
> For example a randconfig caused the following error:
> ERROR: "csum_partial" [fs/reiserfs/reiserfs.ko] undefined!
>
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> ---
> Unless there are any objections I'll apply this patch for v3.11. I'm
> assuming *_ksyms.c is the way that this problem is normally worked
> around.
Actually, normally those files are obj-y not lib-y. See the top-level
lib/.
Subtle, I know.
Cheers,
Rusty.
next prev parent reply other threads:[~2013-07-03 1:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-02 14:07 [PATCH] metag: move EXPORT_SYMBOLs in libs to metag_ksyms.c James Hogan
2013-07-03 0:45 ` Rusty Russell [this message]
2013-07-03 8:44 ` James Hogan
2013-07-03 8:44 ` James Hogan
2013-07-03 8:50 ` Geert Uytterhoeven
2013-07-03 9:14 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bo6kfp32.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=james.hogan@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.