From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51149)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1UpCCj-00027H-Uz
	for qemu-devel@nongnu.org; Wed, 19 Jun 2013 02:49:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1UpCCf-0008Mw-Ae
	for qemu-devel@nongnu.org; Wed, 19 Jun 2013 02:49:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:1068)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1UpCCf-0008Ms-1Z
	for qemu-devel@nongnu.org; Wed, 19 Jun 2013 02:49:13 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1371208516-7857-1-git-send-email-armbru@redhat.com>
	<1371208516-7857-16-git-send-email-armbru@redhat.com>
	<8761xgg5n5.fsf@codemonkey.ws>
Date: Wed, 19 Jun 2013 08:49:06 +0200
In-Reply-To: <8761xgg5n5.fsf@codemonkey.ws> (Anthony Liguori's message of
	"Fri, 14 Jun 2013 08:53:50 -0500")
Message-ID: <87bo72oasd.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v3 15/16] boot-order-test: Support fw_cfg
	in I/O space
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, alex.williamson@redhat.com, aviksil@linux.vnet.ibm.com, afaerber@suse.de

Anthony Liguori <aliguori@us.ibm.com> writes:

> Markus Armbruster <armbru@redhat.com> writes:
>
>> Next commit needs it.
>>
>> Cc: Blue Swirl <blauwirbel@gmail.com>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>  tests/boot-order-test.c | 24 ++++++++++++++++--------
>>  1 file changed, 16 insertions(+), 8 deletions(-)
>>
>> diff --git a/tests/boot-order-test.c b/tests/boot-order-test.c
>> index 7b1edc1..d1d99f8 100644
>> --- a/tests/boot-order-test.c
>> +++ b/tests/boot-order-test.c
>> @@ -133,23 +133,31 @@ static void test_prep_boot_order(void)
>>      test_boot_orders("prep", read_boot_order_prep, test_cases_prep);
>>  }
>>  
>> -static void read_fw_cfg(uint64_t cfg_addr, uint16_t cmd,
>> +static void read_fw_cfg(uint64_t cfg_addr, bool addr_is_io, uint16_t cmd,
>>                          void *buf, size_t len)
>
> I missed it earlier, but you can use libqos/fw_cfg.h for this.

Missed on rebase, thanks for pointing it out.

Two options:

(1) You commit this minor code duplication now, and I promise to clean
    it up in a follow-up series.

(2) You tell me to rework this series so it uses libqos/fw_cfg.h from
    the start.

I'd prefer (1).