From: Jani Nikula <jani.nikula@linux.intel.com>
To: Sean Paul <seanpaul@chromium.org>,
devicetree-discuss@lists.ozlabs.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i2c: Add driver for PTN3460 LVDS/DP bridge
Date: Fri, 25 Jan 2013 10:56:52 +0200 [thread overview]
Message-ID: <87bocdtzcb.fsf@intel.com> (raw)
In-Reply-To: <1359050946-25061-1-git-send-email-seanpaul@chromium.org>
On Thu, 24 Jan 2013, Sean Paul <seanpaul@chromium.org> wrote:
> +static int ptn3460_power_up(struct ptn3460_platform_data *pd)
> +{
> + int ret;
> +
> + if (pd->gpio_pd_n > 0)
> + gpio_set_value(pd->gpio_pd_n, 1);
Hi Sean, just a random thing that caught my eye: last I checked 0 is a
valid GPIO number. You can use gpio_is_valid() on the GPIO numbers.
BR,
Jani.
next prev parent reply other threads:[~2013-01-25 8:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 18:09 [PATCH] drm/i2c: Add driver for PTN3460 LVDS/DP bridge Sean Paul
[not found] ` <1359050946-25061-1-git-send-email-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2013-01-24 21:22 ` Daniel Vetter
[not found] ` <CAKMK7uGQredcS=rqH+m8uDKb72mszOxY6HPjcJpj5g0AwhHvOw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-01-24 21:39 ` Sean Paul
2013-01-25 8:56 ` Jani Nikula [this message]
[not found] ` <87bocdtzcb.fsf-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-01-28 21:43 ` [PATCH v2] " Sean Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bocdtzcb.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.