From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TkcPq-0008Rg-Qv for qemu-devel@nongnu.org; Mon, 17 Dec 2012 10:15:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TkcPi-0006kK-W2 for qemu-devel@nongnu.org; Mon, 17 Dec 2012 10:15:38 -0500 From: Markus Armbruster References: <1355753160-17544-1-git-send-email-armbru@redhat.com> <1355753160-17544-2-git-send-email-armbru@redhat.com> <6CCD7939-E75F-4EE1-A616-8BD90F4443B2@suse.de> <874njkrb7d.fsf@blackfin.pond.sub.org> Date: Mon, 17 Dec 2012 16:15:27 +0100 In-Reply-To: (Alexander Graf's message of "Mon, 17 Dec 2012 15:55:37 +0100") Message-ID: <87bodspv5c.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 01/10] ide: Break all non-qdevified controllers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: kwolf@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org Alexander Graf writes: > On 17.12.2012, at 15:43, Markus Armbruster wrote: > >> Alexander Graf writes: >> >>> On 17.12.2012, at 15:05, Markus Armbruster wrote: >>> >>>> They complicate IDE data structures and keep getting in the way. >>>> Also, TRIM support (commit d353fb72) is broken for them, because >>>> ide_identify() accesses IDEDevice member conf, but IDEDevice exists >>>> only with qdevified controllers. >>>> >>>> The non-qdevified controllers are still there, but attempting to >>>> connect devices to them fails with "IDE controller not qdevified yet; >>>> drive ignored". >>>> >>>> Affected machines: >>>> >>>> * g3beige's first IDE channel (MacIO) >>>> -hda, -hdb are on first channel, and no longer work >>>> -hdc, -hdd are on second channel, and still work >>>> * mac99's second and third IDE channel (MacIO) >>>> All four IDE drives no longer work >>> >>> Nack. This breaks the default targets of qemu-system-ppc and >>> qemu-system-ppc64. >> >> Please tell us how much more time you want to qdevify IDE for these >> targets. Thanks! > > I don't know. If it's dear to you, just convert it > yourself. Apparently you're quite deep into the details here already, > so it's a lot easier for you than for me anyways. These controllers aren't dear to me, they're in the way. Have been for years. I doubt hacking them is easier for me than for you.