Re: [PATCH 2/3] lib: Add formal Kconfig parameter "BCH_CONST_PARAMS"

[Robert Jarzmik <robert.jarzmik@free.fr>]

Alexander Shiyan <shc_work@mail.ru> writes:

> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
>  lib/Kconfig |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/lib/Kconfig b/lib/Kconfig
> index 5966386..febb434 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -20,6 +20,9 @@ config GENERIC_FIND_NEXT_BIT
>  config PROCESS_ESCAPE_SEQUENCE
>  	def_bool n
>  
> +config BCH_CONST_PARAMS
> +	bool
> +
>  source lib/lzo/Kconfig

No, this is incomplete.
If you want to enable compiler optimization of BCH algorithm, you should define
also :
config BCH_CONST_M
	int
	range 5 15
	help
	  Constant value for Galois field order 'm'. If 'k' is the
	  number of data bits to protect, 'm' should be chosen such
	  that (k + m*t) <= 2**m - 1.
	  Drivers should declare a default value for this symbol if
	  they select option BCH_CONST_PARAMS.

config BCH_CONST_T
	int
	help
	  Constant value for error correction capability in bits 't'.
	  Drivers should declare a default value for this symbol if
	  they select option BCH_CONST_PARAMS.

-- 
Robert

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox