From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>, Jiri Olsa <jolsa@redhat.com>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 3/3] perf diff: Use internal rb tree for compute resort
Date: Wed, 05 Dec 2012 00:03:28 +0900 [thread overview]
Message-ID: <87boe9c11b.fsf@kernel.org> (raw)
In-Reply-To: <20121204134544.GB3159@ghostprotocols.net> (Arnaldo Carvalho de Melo's message of "Tue, 4 Dec 2012 10:45:44 -0300")
On Tue, 4 Dec 2012 10:45:44 -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Dec 04, 2012 at 01:44:25PM +0900, Namhyung Kim escreveu:
>> From: Namhyung Kim <namhyung.kim@lge.com>
>>
>> There's no reason to run hists_compute_resort() using output tree.
>> Convert it to use internal tree so that it can remove unnecessary
>> _output_resort. Also move position computation below the resort since
>> it changes the output ordering.
>
> Have you tested this with 'perf top'? With the highest frequency?
After testing 'perf top -F 100000' couple of minutes, I couldn't find
any visible problem. Basically this patchset changes hists__link/match
path which only called from 'perf diff' - I'm working on making use of
that for event group report though. So I didn't check perf top side
seriously. Any reason do you mention it that I'm missing?
Thanks,
Namhyung
next prev parent reply other threads:[~2012-12-04 15:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 4:44 [PATCH 0/3] perf hists: Changes on hists__{link,match} Namhyung Kim
2012-12-04 4:44 ` [PATCH 1/3] perf hists: Exchange order of comparing items when collapsing hists Namhyung Kim
2012-12-04 13:44 ` Arnaldo Carvalho de Melo
2012-12-04 14:57 ` Namhyung Kim
2012-12-04 4:44 ` [PATCH 2/3] perf hists: Link hist entries before inserting to an output tree Namhyung Kim
2012-12-04 4:44 ` [PATCH 3/3] perf diff: Use internal rb tree for compute resort Namhyung Kim
2012-12-04 13:45 ` Arnaldo Carvalho de Melo
2012-12-04 15:03 ` Namhyung Kim [this message]
2012-12-04 13:54 ` [PATCH 0/3] perf hists: Changes on hists__{link,match} Jiri Olsa
-- strict thread matches above, loose matches on Subject: below --
2012-12-05 6:56 [PATCH v2 0/3] perf hists: Changes on hists__{match,link} Namhyung Kim
2012-12-05 6:56 ` [PATCH 3/3] perf diff: Use internal rb tree for compute resort Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87boe9c11b.fsf@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.