From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47263)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1T0sao-0002BJ-OW
	for qemu-devel@nongnu.org; Mon, 13 Aug 2012 07:13:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1T0san-0000fL-TO
	for qemu-devel@nongnu.org; Mon, 13 Aug 2012 07:13:54 -0400
Received: from mx1.redhat.com ([209.132.183.28]:17220)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1T0san-0000fF-LD
	for qemu-devel@nongnu.org; Mon, 13 Aug 2012 07:13:53 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1344513263-22971-1-git-send-email-peter.maydell@linaro.org>
	(Peter Maydell's message of "Thu, 9 Aug 2012 12:54:23 +0100")
References: <1344513263-22971-1-git-send-email-peter.maydell@linaro.org>
Date: Mon, 13 Aug 2012 13:12:53 +0200
Message-ID: <87boifxcy2.fsf@elfo.mitica>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH] vmstate: Add support for saving/loading
	bitmaps
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Igor Mitsyanko <i.mitsyanko@samsung.com>, qemu-devel@nongnu.org, patches@linaro.org

Peter Maydell <peter.maydell@linaro.org> wrote:
> Add support for saving/loading bitmap.h bitmaps in vmstate.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> This will be needed for saving/restoring the bitmap in sd.c which
> is introduced by Igor's latest patchset; the relevant VMSTATE line is:
>         VMSTATE_BITMAP(wp_groups, SDState, 1, wpgrps_size),
> (and you'll need to make wpgrps_size an int32_t, not uint32_t).
>
> Igor: I've only tested this fairly lightly, you'll probably want to
> do things like testing save on 32 bit and load on 64 bit and
> vice-versa.
>
>  savevm.c  |   41 +++++++++++++++++++++++++++++++++++++++++
>  vmstate.h |   13 +++++++++++++
>  2 files changed, 54 insertions(+)

Reviewed-by: Juan Quintela <quintela@redhat.com>

I haven't tested it, but Igor did, so O;-)

I can add it to my next pull request, or let it on Igor one that is the
one using it.  Both ways work for me.