All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Stefan Weil <sw@weilnetz.de>, Anthony Liguori <anthony@codemonkey.ws>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	rjones@redhat.com, Avi Kivity <avi@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] configure: fix libcap detection
Date: Tue, 31 Jul 2012 23:05:35 +0530	[thread overview]
Message-ID: <87boivkf4o.fsf@skywalker.in.ibm.com> (raw)
In-Reply-To: <501808CB.9090009@weilnetz.de>

Stefan Weil <sw@weilnetz.de> writes:

> Am 31.07.2012 08:52, schrieb Aneesh Kumar K.V:
>> Avi Kivity <avi@redhat.com> writes:
>>
>>>   - avoid assigned-but-not-used error
>>>   - avoid missing return error
>>>
>>> Signed-off-by: Avi Kivity <avi@redhat.com>
>>
>> Acked-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>>
>> 	
>>> ---
>>>   configure | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/configure b/configure
>>> index 7767aca..5fb449d 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -2099,7 +2099,7 @@ if test "$cap" != "no" ; then
>>>     cat > $TMPC <<EOF
>>>   #include <stdio.h>
>>>   #include <sys/capability.h>
>>> -int main(void) { cap_t caps; caps = cap_init(); }
>>> +int main(void) { cap_t caps; caps = cap_init(); (void)caps; return 0; }
>>>   EOF
>>>     if compile_prog "" "-lcap" ; then
>>>       cap=yes
>>> -- 
>>> 1.7.11.3
>
>
> Hi Anthony,
>
> please apply http://patchwork.ozlabs.org/patch/171067/,
> or we'll get a 4th bug fix for this.

I sent a pull request for VirtFS taking the patch done by you
found at

http://patchwork.ozlabs.org/patch/171704/ 

That patch is important for VirtFS because without that VirtFS won't
be enabled in the build.

Let me know if you want me to redo the pull request.

-aneesh

      parent reply	other threads:[~2012-07-31 17:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-30 11:41 [Qemu-devel] [PATCH] configure: fix libcap detection Avi Kivity
2012-07-30 12:58 ` Peter Maydell
2012-07-30 22:04 ` Richard W.M. Jones
2012-07-31  6:52 ` Aneesh Kumar K.V
2012-07-31 16:33   ` Stefan Weil
2012-07-31 16:40     ` Peter Maydell
2012-07-31 17:06       ` Blue Swirl
2012-07-31 17:56       ` Blue Swirl
2012-07-31 17:59         ` Peter Maydell
2012-07-31 17:35     ` Aneesh Kumar K.V [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87boivkf4o.fsf@skywalker.in.ibm.com \
    --to=aneesh.kumar@linux.vnet.ibm.com \
    --cc=anthony@codemonkey.ws \
    --cc=avi@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rjones@redhat.com \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.