From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Joe Perches <joe@perches.com>
Cc: Namjae Jeon <linkinjeon@gmail.com>,
linux-kernel@vger.kernel.org,
Amit Sahrawat <amit.sahrawat83@gmail.com>
Subject: Re: [PATCH 2/2] fat: use fat_msg_ratelimit in fat__get_entry.
Date: Mon, 14 May 2012 01:07:11 +0900 [thread overview]
Message-ID: <87bolsdpzk.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <1336924011.31383.6.camel@joe2Laptop> (Joe Perches's message of "Sun, 13 May 2012 08:46:51 -0700")
Joe Perches <joe@perches.com> writes:
> On Sun, 2012-05-13 at 07:03 -0400, Namjae Jeon wrote:
>> So this patch use fat_msg_ratelimit function about this message to decrease this messages.
> []
>> diff --git a/fs/fat/dir.c b/fs/fat/dir.c
>> index aca191b..b2cdbf4 100644
>> --- a/fs/fat/dir.c
>> +++ b/fs/fat/dir.c
>> @@ -98,8 +98,8 @@ next:
>>
>> *bh = sb_bread(sb, phys);
>> if (*bh == NULL) {
>> - fat_msg(sb, KERN_ERR, "Directory bread(block %llu) failed",
>> - (llu)phys);
>> + fat_msg_ratelimit(sb, KERN_ERR, "Directory bread(block %llu) "
>> + "failed", (llu)phys);
>
> Please don't split format strings.
> It's much harder to grep.
Please fight with 80 columns guys before requesting it.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2012-05-13 16:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-13 11:03 [PATCH 2/2] fat: use fat_msg_ratelimit in fat__get_entry Namjae Jeon
2012-05-13 14:24 ` OGAWA Hirofumi
2012-05-13 15:46 ` Joe Perches
2012-05-13 16:07 ` OGAWA Hirofumi [this message]
2012-05-13 16:21 ` Joe Perches
2012-05-13 16:39 ` OGAWA Hirofumi
2012-05-13 23:03 ` Namjae Jeon
-- strict thread matches above, loose matches on Subject: below --
2012-05-15 14:46 Namjae Jeon
2012-05-15 15:11 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bolsdpzk.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=amit.sahrawat83@gmail.com \
--cc=joe@perches.com \
--cc=linkinjeon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.