From: Kevin Hilman <khilman-l0cyMroinI0@public.gmane.org>
To: "T Krishnamoorthy, Balaji" <balajitk-l0cyMroinI0@public.gmane.org>
Cc: ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
b-cousson-l0cyMroinI0@public.gmane.org,
andy.green-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
andy-/Zus8d0mwwtBDgjK7y7TUQ@public.gmane.org,
tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
peter.maydell-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
Jan Weitzel <j.weitzel-guT5V/WYfQezQB+pC5nmwQ@public.gmane.org>,
Shubhrajyoti Datta <shubhrajyoti-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH] ARM: OMAP2+ i2c NACK without STP
Date: Tue, 03 Jan 2012 16:07:04 -0800 [thread overview]
Message-ID: <87boqk8h5j.fsf@ti.com> (raw)
In-Reply-To: <CANrkHUZ530H+0+YKy2QJPFbwUQ1zqD=OaSrF6ByTbpx6eU421Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> (T. Krishnamoorthy's message of "Tue, 27 Dec 2011 20:18:21 +0530")
"T Krishnamoorthy, Balaji" <balajitk-l0cyMroinI0@public.gmane.org> writes:
> On Tue, Jun 14, 2011 at 4:24 PM, Jan Weitzel <j.weitzel-guT5V/WYfQezQB+pC5nmwQ@public.gmane.org> wrote:
>> On OMAP4 OMAP_I2C_STAT_NACK is causing a timeout on the next access.
>> The isr cleans all flags in OMAP_I2C_CON_REG by setting OMAP_I2C_CON_STP
>> OMAP_I2C_CON_STP is also set in omap_i2c_xfer_msg on the last message.
>>
>> According to the TI TSR the sequence for OMAP_I2C_STAT_NACK and
>> OMAP_I2C_STAT_AL are nearly the same.
>> Removing the OMAP_I2C_CON_STP part in the isr fix the problem.
>> Tested on OMAP4430 and OMAP3530 (here NACK was not a problem)
>> Fixes also booting on 2430sdp.
>>
>> Signed-off-by: Jan Weitzel <j.weitzel-guT5V/WYfQezQB+pC5nmwQ@public.gmane.org>
>> Acked-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
>
> Acked-by: Balaji T K <balajitk-l0cyMroinI0@public.gmane.org>
> Can you please queue this patch
>
> This patch has been tested in linux-omap tree
> http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap.git;a=commit;h=464fca36d98b97ccd05e4f200ab7483d3acc8345
I have this patch in my queue (branch: for_3.3/i2c/misc), but
unfortunately, the maintainer has not responded to any of my queries or
pull requests for a couple months now.
I have sent some more off-list queries recently in hopes to get this
moving again.
Kevin
next prev parent reply other threads:[~2012-01-04 0:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 11:47 [PATCH] ARM: omap4: i2c reset regs postidle Jan Weitzel
2011-04-21 12:13 ` Andy Green
2011-05-16 7:56 ` Jan Weitzel
2011-05-16 8:13 ` Andy Green
2011-05-16 9:18 ` [PATCH v2] " Jan Weitzel
2011-05-16 17:16 ` Cousson, Benoit
2011-05-17 9:26 ` [PATCH v3] " Jan Weitzel
2011-05-17 14:12 ` Kevin Hilman
2011-05-18 13:07 ` Jan Weitzel
2011-05-18 14:09 ` Kevin Hilman
2011-06-14 10:05 ` [RFC] ARM: OMAP2+ i2c NACK without STP Jan Weitzel
2011-06-14 10:24 ` Tony Lindgren
[not found] ` <20110614102409.GN3352-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2011-06-14 10:54 ` [PATCH] " Jan Weitzel
2011-12-27 14:48 ` T Krishnamoorthy, Balaji
[not found] ` <CANrkHUZ530H+0+YKy2QJPFbwUQ1zqD=OaSrF6ByTbpx6eU421Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-01-04 0:07 ` Kevin Hilman [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-01-04 14:42 Mark Olleson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87boqk8h5j.fsf@ti.com \
--to=khilman-l0cymroini0@public.gmane.org \
--cc=andy-/Zus8d0mwwtBDgjK7y7TUQ@public.gmane.org \
--cc=andy.green-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=b-cousson-l0cyMroinI0@public.gmane.org \
--cc=balajitk-l0cyMroinI0@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=j.weitzel-guT5V/WYfQezQB+pC5nmwQ@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=peter.maydell-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=shubhrajyoti-l0cyMroinI0@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.