From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 09/15] Makefile.package.in: Pass non-prefixed name as argument to GENTARGETS_INNER.
Date: Fri, 30 Sep 2011 08:31:43 +0200 [thread overview]
Message-ID: <87bou2o81c.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <18450fde69c3d4bc8e309ddf4dfedc78ff4e60a0.1317325743.git.thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Thu, 29 Sep 2011 21:57:45 +0200")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Thomas> From: Quotient Remainder <quotientvremainder@gmail.com>
Thomas> Instead of effectively running s/^host-// on the package name,
Thomas> just pass the non-prefixed name to GENTARGETS_INNER. This
Thomas> removes the need to ban packages with names starting with
Thomas> "host-".
Thomas> Signed-off-by: Quotient Remainder <quotientvremainder@gmail.com>
As I said before, real name please.
Thomas> #
Thomas> # Build step. Only define it if not already defined by the package .mk
Thomas> # file.
Thomas> #
Thomas> -ifndef $(2)_BUILD_CMDS
Thomas> -ifeq ($(5),target)
Thomas> -define $(2)_BUILD_CMDS
Thomas> +ifndef $(4)_BUILD_CMDS
I believe this should be 3 and not 4. Even with this fixed I have the
build breaking in various odd ways, so I'm dropping this patch for now.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2011-09-30 6:31 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 19:57 [Buildroot] [pull request] Pull request for branch for-2011.11/pkg-infra Thomas Petazzoni
2011-09-29 19:57 ` [Buildroot] [PATCH 01/15] package: enhance infrastructure to support source dir override Thomas Petazzoni
2011-09-29 19:57 ` [Buildroot] [PATCH 02/15] package: add configuration option to specify a local override file Thomas Petazzoni
2011-09-29 19:57 ` [Buildroot] [PATCH 03/15] package: add <pkg>-rebuild and <pkg>-reconfigure Thomas Petazzoni
2011-09-29 19:57 ` [Buildroot] [PATCH 04/15] package: implement a 'local' site method Thomas Petazzoni
2011-09-29 19:57 ` [Buildroot] [PATCH 05/15] package: add helper functions to get package name and directory magically Thomas Petazzoni
2011-09-29 19:57 ` [Buildroot] [PATCH 06/15] package: remove useless arguments from GENTARGETS Thomas Petazzoni
2011-09-29 19:57 ` [Buildroot] [PATCH 07/15] package: remove useless arguments from AUTOTARGETS Thomas Petazzoni
2011-09-29 19:57 ` [Buildroot] [PATCH 08/15] package: remove useless arguments from CMAKETARGETS Thomas Petazzoni
2011-09-29 19:57 ` [Buildroot] [PATCH 09/15] Makefile.package.in: Pass non-prefixed name as argument to GENTARGETS_INNER Thomas Petazzoni
2011-09-30 6:31 ` Peter Korsgaard [this message]
2011-09-29 19:57 ` [Buildroot] [PATCH 10/15] Add support for local packages through 'file://' pseudo-protocol Thomas Petazzoni
2011-09-29 19:57 ` [Buildroot] [PATCH 11/15] fakeroot: remove target package Thomas Petazzoni
2011-09-29 19:57 ` [Buildroot] [PATCH 12/15] dhrystone: use the <pkg>_EXTRACT_CMDS mechanism Thomas Petazzoni
2011-09-29 19:57 ` [Buildroot] [PATCH 13/15] whetstone: " Thomas Petazzoni
2011-09-29 19:57 ` [Buildroot] [PATCH 14/15] mcookie: convert to the GENTARGETS infrastructure Thomas Petazzoni
2011-09-29 19:57 ` [Buildroot] [PATCH 15/15] package: normalize output of 'make external-deps' Thomas Petazzoni
2011-09-29 21:37 ` [Buildroot] [pull request] Pull request for branch for-2011.11/pkg-infra Peter Korsgaard
2011-09-30 4:51 ` Thomas Petazzoni
2011-09-30 6:29 ` Peter Korsgaard
2011-09-30 6:33 ` Thomas Petazzoni
2011-09-30 6:41 ` Peter Korsgaard
2011-09-29 21:47 ` Yann E. MORIN
2011-09-30 7:48 ` Thomas De Schampheleire
2011-09-30 8:03 ` Yann E. MORIN
2011-09-30 13:53 ` Thomas De Schampheleire
2011-09-30 14:32 ` Thomas Petazzoni
2011-10-28 14:08 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bou2o81c.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.