All of lore.kernel.org
 help / color / mirror / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-kernel@vger.kernel.org,
	Denys Vlasenko <vda.linux@googlemail.com>
Subject: Re: [PATCHv2] fat: don't use custom hex_to_bin()
Date: Wed, 28 Sep 2011 08:15:55 +0900	[thread overview]
Message-ID: <87bou5inkk.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <CAHp75Vcdnx28i0s4sKUf+MCruMNq-zdX55f45TcTR7AcO4foSw@mail.gmail.com> (Andy Shevchenko's message of "Tue, 27 Sep 2011 21:06:12 +0300")

Andy Shevchenko <andy.shevchenko@gmail.com> writes:

> Actually here we will change endianess.
> So, my question is what endianess is right here? If the original code
> okay, then patch should be rewritten like this:
>
>      rc = hex2bin(op++, ip + 3, 1);
>      if (rc < 0)
>           return -EINVAL;
>
>      rc = hex2bin(op++, ip + 1, 1);
>      if (rc < 0)
>           return -EINVAL;

Original code may work only for little endian. Well, anyway, the output
should be wchar_t (u16) of native endian.

So, I think it should be something like

	u8 uc[2];
	if (hex2bin(uc, ip + 1, 2) < 0)
        	return -EINVAL;
	*(wchar_t *)op = uc[0] << 8 | uc[1];

This should be readable more.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

  reply	other threads:[~2011-09-27 23:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-23 11:32 [PATCH] alsa: 6fire: don't use custom hex_to_bin() Andy Shevchenko
2011-09-23 11:32 ` [PATCH] fat: " Andy Shevchenko
2011-09-23 12:05   ` Denys Vlasenko
2011-09-23 12:11     ` Andy Shevchenko
2011-09-27 11:48     ` [PATCHv2] " Andy Shevchenko
2011-09-27 17:19       ` OGAWA Hirofumi
2011-09-27 17:52         ` Andy Shevchenko
2011-09-27 18:06         ` Andy Shevchenko
2011-09-27 23:15           ` OGAWA Hirofumi [this message]
2011-09-29 13:07             ` Andy Shevchenko
2011-09-29 14:43               ` OGAWA Hirofumi
2011-09-29 14:54                 ` Andy Shevchenko
2011-09-29 15:19                   ` OGAWA Hirofumi
2011-09-29 15:10                 ` [PATCHv4] " Andy Shevchenko
2011-09-29 15:37                   ` Joe Perches
2011-09-29 18:27                     ` OGAWA Hirofumi
2011-09-29 18:41                       ` Joe Perches
2011-09-29 19:35                         ` OGAWA Hirofumi
2011-09-29 13:15             ` [PATCHv3] " Andy Shevchenko
2011-09-29 14:51               ` OGAWA Hirofumi
2011-09-23 13:22 ` [PATCH] alsa: 6fire: " Takashi Iwai
2011-09-23 13:22   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bou5inkk.fsf@devron.myhome.or.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vda.linux@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.