All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: Michael Jones <michael.jones@matrix-vision.de>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAP2: PM debug: remove leftover debug code
Date: Fri, 05 Aug 2011 08:11:18 -0700	[thread overview]
Message-ID: <87bow3uc4p.fsf@ti.com> (raw)
In-Reply-To: <1312550158-4553-1-git-send-email-michael.jones@matrix-vision.de> (Michael Jones's message of "Fri, 5 Aug 2011 15:15:58 +0200")

Michael Jones <michael.jones@matrix-vision.de> writes:

> commit 20d5d5514981f9a68832bffb27a698545ecba77a left some code
> lying around which doesn't do anything. Clean it up.

Minor: when referencing a commit in a changelog, please also
add the short log.  IOW, the changelog should read:

   commit 20d5d5514981f9a68832bffb27a698545ecba77a (OMAP2: PM debug:
   remove register dumping) left some code lying around which doesn't do
   anything. Clean it up.

> Signed-off-by: Michael Jones <michael.jones@matrix-vision.de>
> ---
>
> It looks to me like if you remove the register dump, the debug if's
> don't do anything at all.

You're right.

Please update the changelog and also Cc the linux-arm-kernel mailing
list on the updated patch.

After that, I'll queue it for v3.2.

Thanks,

Kevin

  reply	other threads:[~2011-08-05 15:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-05 13:15 [PATCH] OMAP2: PM debug: remove leftover debug code Michael Jones
2011-08-05 15:11 ` Kevin Hilman [this message]
2011-08-08  7:46   ` [PATCH v2] " Michael Jones
2011-08-08  7:46     ` Michael Jones
2011-08-26 23:15     ` Kevin Hilman
2011-08-26 23:15       ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bow3uc4p.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=michael.jones@matrix-vision.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.