From: Rusty Russell <rusty@rustcorp.com.au>
To: Amos Kong <akong@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH v2] virtio-spec: Fix wrong bit number of device status
Date: Wed, 08 Jun 2011 09:05:26 +0930 [thread overview]
Message-ID: <87boy9gqpt.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20110607130942.GA16234@t400>
On Tue, 7 Jun 2011 21:09:42 +0800, Amos Kong <akong@redhat.com> wrote:
>
> qemu-kvm/hw/virtio_config.h:
> #define VIRTIO_CONFIG_S_ACKNOWLEDGE 1
> #define VIRTIO_CONFIG_S_DRIVER 2
> #define VIRTIO_CONFIG_S_DRIVER_OK 4
> #define VIRTIO_CONFIG_S_FAILED 0x80
>
> virtio-spec:
> ACKNOWLEDGE(1) :
> DRIVER(2) :
> DRIVER_OK(3) :
> FAILED(128) :
>
> The spec refers to bit numbers and the headers use absolute numbers,
> they are not consistent.
>
> it shoule be 'FAILED(8)'.
> 2^(8-1) = 128
>
> Changes from V1:
> - Fix wrong patch body
>
> Signed-off-by: Amos Kong <akong@redhat.com>
Thanks, applied!
Rusty.
prev parent reply other threads:[~2011-06-08 0:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 12:52 [PATCH] virtio-spec: Fix wrong bit number of device status akong
2011-06-07 13:09 ` [PATCH v2] " Amos Kong
2011-06-07 23:35 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87boy9gqpt.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akong@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.