diff for duplicates of <87bozf962e.fsf@ti.com> diff --git a/a/1.txt b/N1/1.txt index e2a47a4..45638a0 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -7,7 +7,7 @@ Govindraj <govindraj.ti@gmail.com> writes: >> >>>> >>>> ... this is just putting back basically the same thing that was removed in ->>>> patch 1. IOW, this is now being checked for *every* PRCM wakeup, which +>>>> patch 1. ?IOW, this is now being checked for *every* PRCM wakeup, which >>>> is no different than having it in the idle path. >>>> >>>> I thought I understood that you had the SW IRQ triggering working, so @@ -15,7 +15,7 @@ Govindraj <govindraj.ti@gmail.com> writes: >>> >>> Actually I tried few experiments but couldn't get it working. >> ->> What exactly is not working? The interrupt is not firing at all? The +>> What exactly is not working? ? The interrupt is not firing at all? ?The >> driver's ISR is not being called? >> > @@ -48,22 +48,22 @@ problems as well. >>> +++ b/arch/arm/mach-omap2/pm34xx.c >>> @@ -288,6 +288,16 @@ static irqreturn_t prcm_interrupt_handler (int >>> irq, void *dev_id) ->>> do { ->>> if (irqstatus_mpu & (OMAP3430_WKUP_ST_MASK | ->>> OMAP3430_IO_ST_MASK)) { +>>> ? ? ? ? do { +>>> ? ? ? ? ? ? ? ? if (irqstatus_mpu & (OMAP3430_WKUP_ST_MASK | +>>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?OMAP3430_IO_ST_MASK)) { >>> +#if 1 ->>> + /* ->>> + * EXP-1: SET UART1 SOFT IRQ BIT ->>> + * 3430 -SDP UART1 console. ->>> + * M_IRQ_72, INTCPS_ISR_SET ->>> + * 0x4820 0090 + (0x20 * n) ->>> + * bit-8 n = 2 ->>> + */ ->>> + __raw_writel(0x100 , 0x482000D0); +>>> + ? ? ? ? ? ? ? ? ? ? ? /* +>>> + ? ? ? ? ? ? ? ? ? ? ? ?* EXP-1: SET UART1 SOFT IRQ BIT +>>> + ? ? ? ? ? ? ? ? ? ? ? ?* 3430 -SDP UART1 console. +>>> + ? ? ? ? ? ? ? ? ? ? ? ?* M_IRQ_72, INTCPS_ISR_SET +>>> + ? ? ? ? ? ? ? ? ? ? ? ?* 0x4820 0090 + (0x20 * n) +>>> + ? ? ? ? ? ? ? ? ? ? ? ?* bit-8 n = 2 +>>> + ? ? ? ? ? ? ? ? ? ? ? ?*/ +>>> + ? ? ? ? ? ? ? ? ? ? ? __raw_writel(0x100 , 0x482000D0); >>> +#endif ->>> c = _prcm_int_handle_wakeup(); +>>> ? ? ? ? ? ? ? ? ? ? ? ? c = _prcm_int_handle_wakeup(); >>> ->>> /* +>>> ? ? ? ? ? ? ? ? ? ? ? ? /* >>> >>> ----------------------------------- >>> @@ -72,7 +72,7 @@ problems as well. >>> Will remove resume_idle once we have irq_chaining patches available. >> >> Well, I'm not OK with $SUBJECT patch as it is since it's just moving an ->> ugly hack from serial.c to the PRCM ISR. If the hack is going to stay, +>> ugly hack from serial.c to the PRCM ISR. ?If the hack is going to stay, >> then it should stay where it is until it can be fixed for real. > > Now with runtime changes we are cutting clocks independently @@ -98,7 +98,3 @@ done for these wakeup events so we can get away from the above approach all together. Kevin --- -To unsubscribe from this list: send the line "unsubscribe linux-omap" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 40a6492..587eed2 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,18 +4,10 @@ "ref\0BANLkTi=32NfMr7exWpOoPHX7_-Jc0i5LqA@mail.gmail.com\0" "ref\087liylkxdi.fsf@ti.com\0" "ref\0BANLkTinr8n0P31LWPrwL83sWCzVQOqo6=Q@mail.gmail.com\0" - "From\0Kevin Hilman <khilman@ti.com>\0" - "Subject\0Re: [PATCH v2 11/12] OMAP: Serial: Use resume call from prcm to enable uart\0" + "From\0khilman@ti.com (Kevin Hilman)\0" + "Subject\0[PATCH v2 11/12] OMAP: Serial: Use resume call from prcm to enable uart\0" "Date\0Fri, 06 May 2011 08:55:53 -0700\0" - "To\0Govindraj <govindraj.ti@gmail.com>\0" - "Cc\0Govindraj.R <govindraj.raja@ti.com>" - linux-omap@vger.kernel.org - linux-serial@vger.kernel.org - linux-arm-kernel@lists.infradead.org - Tony Lindgren <tony@atomide.com> - Benoit Cousson <b-cousson@ti.com> - Paul Walmsley <paul@pwsan.com> - " Rajendra Nayak <rnayak@ti.com>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "Govindraj <govindraj.ti@gmail.com> writes:\n" @@ -27,7 +19,7 @@ ">>\n" ">>>>\n" ">>>> ... this is just putting back basically the same thing that was removed in\n" - ">>>> patch 1. \302\240IOW, this is now being checked for *every* PRCM wakeup, which\n" + ">>>> patch 1. ?IOW, this is now being checked for *every* PRCM wakeup, which\n" ">>>> is no different than having it in the idle path.\n" ">>>>\n" ">>>> I thought I understood that you had the SW IRQ triggering working, so\n" @@ -35,7 +27,7 @@ ">>>\n" ">>> Actually I tried few experiments but couldn't get it working.\n" ">>\n" - ">> What exactly is not working? \302\240 The interrupt is not firing at all? \302\240The\n" + ">> What exactly is not working? ? The interrupt is not firing at all? ?The\n" ">> driver's ISR is not being called?\n" ">>\n" ">\n" @@ -68,22 +60,22 @@ ">>> +++ b/arch/arm/mach-omap2/pm34xx.c\n" ">>> @@ -288,6 +288,16 @@ static irqreturn_t prcm_interrupt_handler (int\n" ">>> irq, void *dev_id)\n" - ">>> \302\240 \302\240 \302\240 \302\240 do {\n" - ">>> \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 if (irqstatus_mpu & (OMAP3430_WKUP_ST_MASK |\n" - ">>> \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240OMAP3430_IO_ST_MASK)) {\n" + ">>> ? ? ? ? do {\n" + ">>> ? ? ? ? ? ? ? ? if (irqstatus_mpu & (OMAP3430_WKUP_ST_MASK |\n" + ">>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?OMAP3430_IO_ST_MASK)) {\n" ">>> +#if 1\n" - ">>> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 /*\n" - ">>> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240* EXP-1: SET UART1 SOFT IRQ BIT\n" - ">>> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240* 3430 -SDP UART1 console.\n" - ">>> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240* M_IRQ_72, INTCPS_ISR_SET\n" - ">>> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240* 0x4820 0090 + (0x20 * n)\n" - ">>> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240* bit-8 n = 2\n" - ">>> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240*/\n" - ">>> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 __raw_writel(0x100 , 0x482000D0);\n" + ">>> + ? ? ? ? ? ? ? ? ? ? ? /*\n" + ">>> + ? ? ? ? ? ? ? ? ? ? ? ?* EXP-1: SET UART1 SOFT IRQ BIT\n" + ">>> + ? ? ? ? ? ? ? ? ? ? ? ?* 3430 -SDP UART1 console.\n" + ">>> + ? ? ? ? ? ? ? ? ? ? ? ?* M_IRQ_72, INTCPS_ISR_SET\n" + ">>> + ? ? ? ? ? ? ? ? ? ? ? ?* 0x4820 0090 + (0x20 * n)\n" + ">>> + ? ? ? ? ? ? ? ? ? ? ? ?* bit-8 n = 2\n" + ">>> + ? ? ? ? ? ? ? ? ? ? ? ?*/\n" + ">>> + ? ? ? ? ? ? ? ? ? ? ? __raw_writel(0x100 , 0x482000D0);\n" ">>> +#endif\n" - ">>> \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 c = _prcm_int_handle_wakeup();\n" + ">>> ? ? ? ? ? ? ? ? ? ? ? ? c = _prcm_int_handle_wakeup();\n" ">>>\n" - ">>> \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 /*\n" + ">>> ? ? ? ? ? ? ? ? ? ? ? ? /*\n" ">>>\n" ">>> -----------------------------------\n" ">>>\n" @@ -92,7 +84,7 @@ ">>> Will remove resume_idle once we have irq_chaining patches available.\n" ">>\n" ">> Well, I'm not OK with $SUBJECT patch as it is since it's just moving an\n" - ">> ugly hack from serial.c to the PRCM ISR. \302\240If the hack is going to stay,\n" + ">> ugly hack from serial.c to the PRCM ISR. ?If the hack is going to stay,\n" ">> then it should stay where it is until it can be fixed for real.\n" ">\n" "> Now with runtime changes we are cutting clocks independently\n" @@ -117,10 +109,6 @@ "done for these wakeup events so we can get away from the above approach\n" "all together.\n" "\n" - "Kevin\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-omap\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + Kevin -722f8111961fe96a7159a585d3c6870688086f50cc21b60eae5c059608cb912e +c97a72a31e028f959329ff8bf976e110ded3f1dc7cdb403aac49037e222fbfea
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.