From: jacmet@sunsite.dk (Peter Korsgaard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mxc/gpio: make _set_value work with values != 0/1
Date: Mon, 11 Oct 2010 14:23:00 +0200 [thread overview]
Message-ID: <87bp70or4r.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20101011121745.GA12849@jasper.tkos.co.il> (Baruch Siach's message of "Mon, 11 Oct 2010 14:17:46 +0200")
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
Hi,
>> +
Baruch> Unneeded empty line.
Yeah, just noticed as well.
>> spin_lock_irqsave(&port->lock, flags);
>> - l = (__raw_readl(reg) & (~(1 << offset))) | (value << offset);
>> + l = __raw_readl(reg);
>> + if (value)
>> + l |= 1 << offset;
>> + else
>> + l &= ~(1 << offset);
Baruch> Alternative shorter version:
Baruch> l = (__raw_readl(reg) & (~(1 << offset))) | (!!value << offset);
Well, what do you know - I seem to be outnumbered ;)
Sasha, do you want the !! version instead? Then I'll resend.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2010-10-11 12:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-11 11:59 [PATCH] mxc/gpio: make _set_value work with values != 0/1 Peter Korsgaard
2010-10-11 12:12 ` Marc Kleine-Budde
2010-10-11 12:18 ` Peter Korsgaard
2010-10-11 12:15 ` Uwe Kleine-König
2010-10-11 12:21 ` Peter Korsgaard
2010-10-11 13:19 ` Michał Nazarewicz
2010-10-11 12:17 ` Baruch Siach
2010-10-11 12:23 ` Peter Korsgaard [this message]
2010-10-11 12:39 ` Sascha Hauer
2010-10-11 12:47 ` Peter Korsgaard
2010-10-11 12:54 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bp70or4r.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite.dk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.