Re: [PATCH v6 1/7] omap3: pm: fix for twl4030 script load

[Kevin Hilman <khilman@deeprootsystems.com>]

Lesly A M <leslyam@ti.com> writes:

> This patch will fix the TRITON sleep/wakeup sequence.
>
> Since the function to populate the sleep script is getting called always
> irrespective of the flag "TWL4030_SLEEP_SCRIPT", other scripts data
> is getting over written by the sleep script.

OK, this is a clear bug fix and should be a patch on its own.

> Print warning if the sleep script is loaded before wakeup script.
> Because there is a chance that the Power chip may go to sleep before
> the wakeup script is completely loaded, which can cause a system hang.

OK, but your patch doesn't add this warning.  It's already  there.

Kevin

> Signed-off-by: Lesly A M <x0080970@ti.com>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: David Derrick <dderrick@ti.com>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> ---
>  drivers/mfd/twl4030-power.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
> index 7efa878..b4fc190 100644
> --- a/drivers/mfd/twl4030-power.c
> +++ b/drivers/mfd/twl4030-power.c
> @@ -451,12 +451,13 @@ static int __init load_twl4030_script(struct twl4030_script *tscript,
>  		if (err)
>  			goto out;
>  	}
> -	if (tscript->flags & TWL4030_SLEEP_SCRIPT)
> -		if (order)
> +	if (tscript->flags & TWL4030_SLEEP_SCRIPT) {
> +		if (!order)
>  			pr_warning("TWL4030: Bad order of scripts (sleep "\
>  					"script before wakeup) Leads to boot"\
>  					"failure on some boards\n");
>  		err = twl4030_config_sleep_sequence(address);
> +	}
>  out:
>  	return err;
>  }
> -- 
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html