From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Monakhov Subject: [PATCH] pohmelfs: Remove dead quota code Date: Fri, 21 May 2010 11:37:32 +0400 Message-ID: <87bpc9wvr7.fsf@openvz.org> References: <1274386643-24033-1-git-send-email-jack@suse.cz> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Cc: linux-fsdevel@vger.kernel.org, hch@infradead.org, Evgeniy Polyakov To: Jan Kara Return-path: Received: from fg-out-1718.google.com ([72.14.220.156]:54076 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753517Ab0EUHhj (ORCPT ); Fri, 21 May 2010 03:37:39 -0400 Received: by fg-out-1718.google.com with SMTP id d23so923821fga.1 for ; Fri, 21 May 2010 00:37:36 -0700 (PDT) In-Reply-To: <1274386643-24033-1-git-send-email-jack@suse.cz> (Jan Kara's message of "Thu, 20 May 2010 22:17:21 +0200") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: --=-=-= Jan Kara writes: > Two patches below remove dead quota code from UFS and UDF. Quota is > non-functional (quotaon fails) for these filesystems for several years and > noone complained AFAIK. Also the main purpose of these filesystems is > interoperability with other systems and quota support is linux-specific so it > does not make too much sense. So remove the dead code... Awesome. Let's remove dead quota code completely. --=-=-= Content-Disposition: inline; filename=0001-pohmelfs-Remove-dead-quota-code.patch >>From e6095c822e076b426b6684901f9c7a824cdab0d9 Mon Sep 17 00:00:00 2001 From: root Date: Fri, 21 May 2010 11:16:10 +0400 Subject: [PATCH] pohmelfs: Remove dead quota code Quota on pohmelfs is non-functional. IFAIU quota logic was copy-pasted from generic setattr(). Signed-off-by: Dmitry Monakhov --- drivers/staging/pohmelfs/inode.c | 8 -------- 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/drivers/staging/pohmelfs/inode.c b/drivers/staging/pohmelfs/inode.c index 11fc4d5..9123837 100644 --- a/drivers/staging/pohmelfs/inode.c +++ b/drivers/staging/pohmelfs/inode.c @@ -29,7 +29,6 @@ #include #include #include -#include #include "netfs.h" @@ -967,13 +966,6 @@ int pohmelfs_setattr_raw(struct inode *inode, struct iattr *attr) goto err_out_exit; } - if ((attr->ia_valid & ATTR_UID && attr->ia_uid != inode->i_uid) || - (attr->ia_valid & ATTR_GID && attr->ia_gid != inode->i_gid)) { - err = dquot_transfer(inode, attr); - if (err) - goto err_out_exit; - } - err = inode_setattr(inode, attr); if (err) { dprintk("%s: ino: %llu, failed to set the attributes.\n", __func__, POHMELFS_I(inode)->ino); -- 1.6.2.5 --=-=-=--