From: Andi Kleen <andi@firstfloor.org>
To: Yehuda Sadeh <yehuda@hq.newdream.net>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
yehudasa@gmail.com, sage@newdream.net, axboe@kernel.dk
Subject: Re: [PATCH 5/6] ceph: refactor mount related functions, add helpers
Date: Wed, 14 Apr 2010 11:57:53 +0200 [thread overview]
Message-ID: <87bpdm9x0e.fsf@basil.nowhere.org> (raw)
In-Reply-To: <b29a49e98a5186f83094b7a7a5dbc74647921e10.1271198630.git.yehuda@hq.newdream.net> (Yehuda Sadeh's message of "Tue, 13 Apr 2010 16:29:14 -0700")
Yehuda Sadeh <yehuda@hq.newdream.net> writes:
>
> +int ceph_copy_to_page_vector(struct page **pages,
> + const char *data,
> + loff_t off, size_t len)
> +{
> + int i = 0;
> + int po = off & ~PAGE_CACHE_MASK;
> + int left = len;
> + int l;
> +
> + while (left > 0) {
> + l = min_t(int, PAGE_CACHE_SIZE-po, left);
int seems like exactly the wrong type here.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2010-04-14 9:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-13 23:29 [PATCH 0/6] Ceph RADOS block device Yehuda Sadeh
2010-04-13 23:29 ` [PATCH 1/6] ceph: all allocation functions should get gfp_mask Yehuda Sadeh
2010-04-13 23:29 ` [PATCH 2/6] ceph: refactor osdc requests creation functions Yehuda Sadeh
2010-04-13 23:29 ` [PATCH 3/6] ceph: message layer can send/receive data in bio Yehuda Sadeh
2010-04-13 23:29 ` [PATCH 4/6] ceph: enable creation of clients that don't need mds Yehuda Sadeh
2010-04-13 23:29 ` [PATCH 5/6] ceph: refactor mount related functions, add helpers Yehuda Sadeh
2010-04-14 9:57 ` Andi Kleen [this message]
2010-04-14 17:39 ` yehuda
2010-04-13 23:29 ` [PATCH 6/6] ceph: rados block device Yehuda Sadeh
2010-04-13 23:35 ` [PATCH 2/6] ceph: refactor osdc requests creation functions Yehuda Sadeh
2010-04-13 23:35 ` [PATCH 3/6] ceph: message layer can send/receive data in bio Yehuda Sadeh
2010-04-13 23:35 ` [PATCH 4/6] ceph: enable creation of clients that don't need mds Yehuda Sadeh
2010-04-13 23:35 ` [PATCH 5/6] ceph: refactor mount related functions, add helpers Yehuda Sadeh
2010-04-13 23:35 ` [PATCH 6/6] ceph: rados block device Yehuda Sadeh
-- strict thread matches above, loose matches on Subject: below --
2010-04-13 23:35 [PATCH 0/6] Ceph RADOS " Yehuda Sadeh
2010-04-13 23:35 ` [PATCH 1/6] ceph: all allocation functions should get gfp_mask Yehuda Sadeh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bpdm9x0e.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=axboe@kernel.dk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sage@newdream.net \
--cc=yehuda@hq.newdream.net \
--cc=yehudasa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.