All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: Sergio Aguirre <saaguirre@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [RFC part2 v1][PATCH 2/4] omap3: zoom2/3 / 3630sdp: Don't init always all uarts
Date: Mon, 01 Mar 2010 13:12:42 -0800	[thread overview]
Message-ID: <87bpf7bvat.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1267469754-10638-3-git-send-email-saaguirre@ti.com> (Sergio Aguirre's message of "Mon\,  1 Mar 2010 12\:55\:52 -0600")

Sergio Aguirre <saaguirre@ti.com> writes:

> This is useless, since in Zoom2/3 boards, the ports aren't even
> physically accessible.
>
> They must be explicitly initted in the board-zoom2.c, board-zoom3.c
> and board-3630sdp.c files instead.
>
> Signed-off-by: Sergio Aguirre <saaguirre@ti.com>

/me likes

Acked-by: Kevin Hilman <khilman@deeprootsystems.com>

> ---
>  arch/arm/mach-omap2/board-zoom-peripherals.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-zoom-peripherals.c b/arch/arm/mach-omap2/board-zoom-peripherals.c
> index a1011ee..6b39849 100644
> --- a/arch/arm/mach-omap2/board-zoom-peripherals.c
> +++ b/arch/arm/mach-omap2/board-zoom-peripherals.c
> @@ -280,7 +280,6 @@ static void enable_board_wakeup_source(void)
>  void __init zoom_peripherals_init(void)
>  {
>  	omap_i2c_init();
> -	omap_serial_init_allports();
>  	usb_musb_init(&musb_board_data);
>  	enable_board_wakeup_source();
>  }
> -- 
> 1.6.3.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2010-03-01 21:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-01 18:55 [RFC part2 v1][PATCH 0/4] omap2/3/4: Some more serial work Sergio Aguirre
2010-03-01 18:55 ` [RFC part2 v1][PATCH 1/4] omap2/3/4: serial: rename omap_serial_init Sergio Aguirre
2010-03-01 21:10   ` Kevin Hilman
2010-03-01 23:26     ` Aguirre, Sergio
2010-03-01 23:49       ` Kevin Hilman
2010-03-02  0:30         ` Aguirre, Sergio
2010-03-01 18:55 ` [RFC part2 v1][PATCH 2/4] omap3: zoom2/3 / 3630sdp: Don't init always all uarts Sergio Aguirre
2010-03-01 21:12   ` Kevin Hilman [this message]
2010-03-01 18:55 ` [RFC part2 v1][PATCH 3/4] omap3: 3630sdp: Explicitly enable all UARTs Sergio Aguirre
2010-03-01 18:55 ` [RFC part2 v1][PATCH 4/4] omap3: zoom 2/3: Change debugboard serial port id Sergio Aguirre
2010-03-01 21:12   ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bpf7bvat.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=saaguirre@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.