From: Andi Kleen <andi@firstfloor.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Kevin Cernekee <cernekee@gmail.com>,
<linux-kernel@vger.kernel.org>,
Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] Fix virt_to_phys() warnings
Date: Thu, 02 Jul 2009 09:07:46 +0200 [thread overview]
Message-ID: <87bpo3bm0t.fsf@basil.nowhere.org> (raw)
In-Reply-To: <20090701224627.0b2704df.akpm@linux-foundation.org> (Andrew Morton's message of "Wed, 1 Jul 2009 22:46:27 -0700")
Andrew Morton <akpm@linux-foundation.org> writes:
>
> #define virt_to_page(kaddr) pfn_to_page(PFN_DOWN(virt_to_phys(kaddr)))
>
> thereby passing an `unsigned long' where a void* was expected.
>
>
> So perhaps something along these lines:
I'm not quite sure it's the case on MIPS, but I remember on x86 one of
the reasons this was done as a macro was to avoid a include dependency
loop with struct page.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2009-07-02 7:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-27 0:13 [PATCH] Fix virt_to_phys() warnings Kevin Cernekee
2009-07-02 5:46 ` Andrew Morton
2009-07-02 7:07 ` Andi Kleen [this message]
2009-07-02 8:26 ` Ralf Baechle
2009-07-02 10:40 ` Ralf Baechle
2009-07-02 16:25 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bpo3bm0t.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=cernekee@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.