From mboxrd@z Thu Jan  1 00:00:00 1970
From: Markus Armbruster <armbru@redhat.com>
Subject: [PATCH] fbfront: Improve diagnostics when kthread_run()
	fails
Date: Mon, 02 Feb 2009 10:17:22 +0100
Message-ID: <87bptlp599.fsf_-_@pike.pond.sub.org>
References: <497E784B.7060003@jp.fujitsu.com>
	<497ED10A.76E4.0078.0@novell.com> <498009CC.1000101@jp.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <498009CC.1000101@jp.fujitsu.com> (Akio Takebe's message of "Wed\,
	28 Jan 2009 16\:31\:24 +0900")
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Akio Takebe <takebe_akio@jp.fujitsu.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Failure is reported with xenbus_dev_fatal(..."register_framebuffer"),
which was already suboptimal before it got moved away from
register_framebuffer(), and is outright misleading now.

Signed-off-by: Markus Armbruster <armbru@redhat.com>

diff -r 26ddc59c674d drivers/xen/fbfront/xenfb.c
--- a/drivers/xen/fbfront/xenfb.c	Fri Jan 30 10:54:10 2009 +0000
+++ b/drivers/xen/fbfront/xenfb.c	Mon Feb 02 10:12:54 2009 +0100
@@ -211,7 +211,7 @@
 		return;
 
 	mutex_lock(&info->mm_lock);
-	
+
 	spin_lock_irqsave(&info->dirty_lock, flags);
 	if (info->dirty){
 		info->dirty = 0;
@@ -837,7 +837,7 @@
 			if (IS_ERR(info->kthread)) {
 				info->kthread = NULL;
 				xenbus_dev_fatal(dev, PTR_ERR(info->kthread),
-						"register_framebuffer");
+						"xenfb_thread");
 			}
 		}
 		break;