From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] gcc 4.2.2 patch
Date: Fri, 28 Mar 2008 21:59:44 +0100 [thread overview]
Message-ID: <87bq4yh8e7.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20080328204136.GN1783@mx.loc> (Bernhard Fischer's message of "Fri\, 28 Mar 2008 21\:41\:36 +0100")
>>>>> "Bernhard" == Bernhard Fischer <rep.dot.nop@gmail.com> writes:
Bernhard> On Fri, Mar 28, 2008 at 08:22:02PM +0000, Nigel Kukard wrote:
>> Is this patch ok to bump gcc to 4.2.2?
>>
>> I grep -r'd the buildroot tree and replaced each occurrence manually and
>> removed 4.2.0.
>>
>> -N
>> Index: package/lvm2/lvm2.mk
>> ===================================================================
>> --- package/lvm2/lvm2.mk (revision 21539)
>> +++ package/lvm2/lvm2.mk (working copy)
>> @@ -64,7 +64,7 @@
>> $(LVM2_TARGET_SBINS): $(LVM2_DIR)/.configured
>> $(MAKE) CC=$(TARGET_CC) -C $(LVM2_DIR) DESTDIR=$(STAGING_DIR)
>> $(MAKE) CC=$(TARGET_CC) -C $(LVM2_DIR) DESTDIR=$(STAGING_DIR) install
>> - for binary in $(LVM2_SBIN); do echo $$binary; cp -a $(STAGING_DIR)/sbin/$$binary $(TARGET_DIR)/sbin; done
>> + for binary in $(LVM2_SBIN); do echo $$binary; install -m0755 -p $(STAGING_DIR)/sbin/$$binary $(TARGET_DIR)/sbin; done
Bernhard> close.
Bernhard> Correct would have been to use $(INSTALL). Also the for
Bernhard> loop doesn't make too much sense, fwiw.
What does this hunk have to do with $SUBJ ?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2008-03-28 20:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 20:22 [Buildroot] gcc 4.2.2 patch Nigel Kukard
2008-03-28 20:41 ` Bernhard Fischer
2008-03-28 20:59 ` Peter Korsgaard [this message]
2008-03-28 21:10 ` Bernhard Fischer
2008-03-28 21:16 ` Nigel Kukard
2008-03-28 21:03 ` Nigel Kukard
2008-03-28 21:13 ` Bernhard Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bq4yh8e7.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.