From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1JMszb-0007xa-8j
	for mharc-grub-devel@gnu.org; Wed, 06 Feb 2008 17:43:47 -0500
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JMszZ-0007vm-5x
	for grub-devel@gnu.org; Wed, 06 Feb 2008 17:43:45 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JMszY-0007um-9J
	for grub-devel@gnu.org; Wed, 06 Feb 2008 17:43:44 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JMszY-0007uW-49
	for grub-devel@gnu.org; Wed, 06 Feb 2008 17:43:44 -0500
Received: from neonescio.viaisn.org ([82.94.249.43])
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <jeroen@dekkers.cx>) id 1JMszX-0000qY-MN
	for grub-devel@gnu.org; Wed, 06 Feb 2008 17:43:43 -0500
Received: from dijkstra.dekkers.cx ([2001:960:7a0:0:213:d4ff:fe9c:2487]
	ident=Debian-exim)
	by neonescio.viaisn.org with esmtpsa (TLS-1.0:RSA_AES_256_CBC_SHA1:32
	CV=0) (Exim 4.63 #1)
	id 1JMszU-0007pn-LV; Wed, 06 Feb 2008 23:43:40 +0100
Received: from localhost ([127.0.0.1] helo=dijkstra.dekkers.cx ident=jeroen)
	by dijkstra.dekkers.cx with esmtp (Exim 4.68)
	(envelope-from <jeroen@dekkers.cx>)
	id 1JMszT-0003RB-UM; Wed, 06 Feb 2008 23:43:40 +0100
Date: Wed, 06 Feb 2008 23:43:39 +0100
Message-ID: <87bq6thfj8.wl@dekkers.cx>
From: Jeroen Dekkers <jeroen@vrijschrift.org>
To: Robert Millan <rmh@aybabtu.com>
In-Reply-To: <20080206164507.GA3287@thorin>
References: <20080206164507.GA3287@thorin>
User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.9
	(=?ISO-8859-4?Q?Goj=F2?=) APEL/10.7 Emacs/22.1 (x86_64-pc-linux-gnu)
	MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3)
Cc: grub-devel@gnu.org
Subject: Re: [PATCH] simplify grub_raid_array
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Feb 2008 22:43:45 -0000

At Wed, 6 Feb 2008 17:45:07 +0100,
Robert Millan wrote:
> Unless I missed something, it seems that grub_raid_array contains redundant
> information (`name' is already present via `disk->name').  I propose to
> simplify it this way.

No idea why, I don't have the time to look at the actual code, but 
 
> @@ -410,7 +410,7 @@ grub_raid_scan_device (const char *name)
>  	  return 0;
>  	}
>    
> -      if (array->device[sb.this_disk.number].name != 0)
> +      if (array->device[sb.this_disk.number]->name != 0)
>  	{
>  	  /* We found multiple devices with the same number. Again,
>  	     this shouldn't happen.*/

looks suspicious to me. Is that really doing what it is meant to do?


Regards,

Jeroen Dekkers