From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JJlw2-0005cy-94 for mharc-grub-devel@gnu.org; Tue, 29 Jan 2008 03:35:14 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JJlw1-0005ct-5I for grub-devel@gnu.org; Tue, 29 Jan 2008 03:35:13 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JJlvz-0005ch-0D for grub-devel@gnu.org; Tue, 29 Jan 2008 03:35:12 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JJlvy-0005ce-NW for grub-devel@gnu.org; Tue, 29 Jan 2008 03:35:10 -0500 Received: from smtp-vbr13.xs4all.nl ([194.109.24.33]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JJlvy-0003OR-8u for grub-devel@gnu.org; Tue, 29 Jan 2008 03:35:10 -0500 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr13.xs4all.nl (8.13.8/8.13.8) with ESMTP id m0T8Z8a9089577 for ; Tue, 29 Jan 2008 09:35:09 +0100 (CET) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <1201490732.20392.15.camel@rd> <20080128090910.GC13368@thorin> Mail-Copies-To: mgerards@xs4all.nl Date: Tue, 29 Jan 2008 09:36:41 +0100 In-Reply-To: <20080128090910.GC13368@thorin> (Robert Millan's message of "Mon, 28 Jan 2008 10:09:10 +0100") Message-ID: <87bq75c9k6.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: Redefining GRUB_MOD_GAP in init.c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jan 2008 08:35:13 -0000 Robert Millan writes: > On Sun, Jan 27, 2008 at 10:25:32PM -0500, Pavel Roskin wrote: >> Hi Robert, >> >> I'm concerned about your latest commit: >> >> * kern/powerpc/ieee1275/init.c (grub_arch_modules_addr): Skip >> `GRUB_MOD_GAP' for platforms in which it's not defined. >> >> The algorithm for calculating the start of the modules should be exactly >> the same in grub-mkimage and in the core. Any fallbacks should be >> coherent if possible. Therefore, I think it would be better to define >> GRUB_MOD_GAP only in header files. > > Sorry, I should've really sent this for review; it wasn't such an obvious fix > as you pointed out. I'll get that moved to headers as you suggest. > >> Also, I don't see how GRUB_MOD_GAP would not be defined to 0x8000 for >> i386-ieee1275 platform considering that >> include/grub/i386/ieee1275/kernel.h simply includes >> include/grub/powerpc/ieee1275/kernel.h > > Sounds strange.. I'm wondering that myself. Will check.. > >> It's hard for me to understand why kern/powerpc/ieee1275/init.c can be >> used on any platform other than PowerPC. I was assuming that my changes >> would not affect other platforms. >> >> [...] >> I suggest that i386-ieee1275 stops using any files for PowerPC. >> kernel.h is not big, so it shouldn't be a problem to copy it. As for >> init.c, it should be either copied or moved to a more suitable place. > > I think it's safe to say that the only part of kern/powerpc/ieee1275/init.c > that only works on PowerPC is its name ;-) > > Maybe it's time we move out those generic files under powerpc directory. I > propose moving the following: > > kern/powerpc/ieee1275/init.c > kern/powerpc/ieee1275/cmain.c > kern/powerpc/ieee1275/openfw.c > loader/powerpc/ieee1275/multiboot2.c Move it where? -- Marco