From: Marco Gerards <mgerards@xs4all.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Standalone problem to test syntax rules
Date: Sun, 22 Jul 2007 18:21:18 +0200 [thread overview]
Message-ID: <87bqe4csu9.fsf@xs4all.nl> (raw)
In-Reply-To: <20070722155546.GB2272@ws3.vdp.com> (bean123ch@gmail.com's message of "Sun, 22 Jul 2007 23:55:46 +0800")
Bean <bean123ch@gmail.com> writes:
> On Sun, Jul 22, 2007 at 03:06:49PM +0200, Marco Gerards wrote:
>> You are right that it has advantages. But I prefer using an Abstract
>> Syntax Tree. It is used a lot in most literature on parsers, clean
>> and easy to understand.
>>
>> The disadvantage is that you need a separate free routine for each
>> kind of node. But heck, we can even generalize this!
>>
>> I agree there is a lot of room for improvement. But stepping away
>> from using ASTs is not the way to go in my opinion.
>
> Using AST or binary tree is only a matter of choice. If you think AST is
> better, I will modify the code to use AST.
The code already uses an AST. Or what do you mean?
If I am not mistaken, you are going over parser.y to make it work with
more situations and to introduce proper error handling. Or am I
mistaken?
> Would you take a look at the program, especially the error recover rules.
> I think it can handle all situation, but you never know until it's fully
> tested.
In the tarball?
--
Marco
next prev parent reply other threads:[~2007-07-22 16:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-03 17:53 Standalone problem to test syntax rules Bean
2007-07-03 17:54 ` Bean
2007-07-22 13:06 ` Marco Gerards
2007-07-22 15:55 ` Bean
2007-07-22 16:21 ` Marco Gerards [this message]
2007-07-22 16:34 ` Bean
2007-11-10 18:43 ` Marco Gerards
2007-11-10 19:49 ` Gregg Levine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bqe4csu9.fsf@xs4all.nl \
--to=mgerards@xs4all.nl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.