From: Marco Gerards <mgerards@xs4all.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: gcs doubt #1
Date: Mon, 04 Jun 2007 17:32:36 +0200 [thread overview]
Message-ID: <87bqfv7n1n.fsf@xs4all.nl> (raw)
In-Reply-To: <4665F505.3050703@raulete.net> (adrian15@raulete.net's message of "Wed, 06 Jun 2007 01:43:01 +0200")
adrian15 <adrian15@raulete.net> writes:
> Please put a comment on each function saying what the function does,
> what sorts of arguments it gets, and what the possible values of
> arguments mean and are used for.
>
> Is it ok that the search.c and test.c (commands/ folder) do not have any
> of these comments at all?
The currect test.c is a dummy so the `if' expression can be
used/tested.
If you can provide a patch for sourcecode to improve or add comments
in a sane way, I am willing to commit those patches. Just please
don't make the mistake to add useless comments.
--
Marco
next prev parent reply other threads:[~2007-06-04 15:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-05 23:43 gcs doubt #1 adrian15
2007-06-04 15:32 ` Marco Gerards [this message]
[not found] <200706051834.l55IY56F003249@correoredir01.dinaserver.com>
2007-06-06 18:04 ` adrian15
[not found] <200706041604.l54G4p0v029961@correoredir01.dinaserver.com>
2007-06-05 17:32 ` adrian15
2007-06-05 17:56 ` Marco Gerards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bqfv7n1n.fsf@xs4all.nl \
--to=mgerards@xs4all.nl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.