From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1EZY5W-0001JZ-GD for mharc-grub-devel@gnu.org; Tue, 08 Nov 2005 13:20:54 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EZY5T-0001Ga-6A for grub-devel@gnu.org; Tue, 08 Nov 2005 13:20:51 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EZY5R-0001DI-5W for grub-devel@gnu.org; Tue, 08 Nov 2005 13:20:50 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EZY5Q-0001D0-VN for grub-devel@gnu.org; Tue, 08 Nov 2005 13:20:49 -0500 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EZY5R-00032G-01 for grub-devel@gnu.org; Tue, 08 Nov 2005 13:20:49 -0500 Received: from vscan-cn.han.nl (venus.han.nl [145.74.65.6]) by mail-cn.han.nl (Postfix) with ESMTP id CC7E48668 for ; Tue, 8 Nov 2005 19:20:47 +0100 (CET) Received: from mail-cn.han.nl ([145.74.66.11]) by vscan-cn.han.nl (venus.han.nl [145.74.65.6]) (amavisd-new, port 10024) with ESMTP id 15823-05 for ; Tue, 8 Nov 2005 19:20:47 +0100 (CET) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id 073AE859A for ; Tue, 8 Nov 2005 19:20:47 +0100 (CET) Received: from localhost.localdomain (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id CD747C045 for ; Tue, 8 Nov 2005 19:20:46 +0100 (CET) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <28ec5adc7b401784d274908e3a641565@penguinppc.org> From: Marco Gerards Date: Tue, 08 Nov 2005 19:20:47 +0100 In-Reply-To: <28ec5adc7b401784d274908e3a641565@penguinppc.org> (Hollis Blanchard's message of "Mon, 7 Nov 2005 22:55:04 -0600") Message-ID: <87br0vknls.fsf@student.han.nl> User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new (2.2.0) at vscan-cn.han.nl Subject: Re: [ppc patch] fix line-wrapping X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Nov 2005 18:20:51 -0000 Hollis Blanchard writes: > This patch fixes the line-wrapping problems we've been having on > PPC. I rearranged grub_ofconsole_getwh() slightly to avoid excessive > indentation. I will apply soon unless people criticize my ChangeLog > entry. ;) Great! This was a very annoying bug. > Index: ChangeLog > =================================================================== > RCS file: /cvsroot/grub/grub2/ChangeLog,v > retrieving revision 1.193 > diff -u -p -r1.193 ChangeLog > --- ChangeLog 7 Nov 2005 22:28:55 -0000 1.193 > +++ ChangeLog 8 Nov 2005 04:50:12 -0000 > @@ -1,3 +1,12 @@ > +2005-11-03 Hollis Blanchard > + > + * term/ieee1275/ofconsole.c (grub_ofconsole_width): New variable. > + (grub_ofconsole_height): Likewise. > + (grub_ofconsole_putchar): If grub_curr_x exceeds console width, > + manually insert a '\n'. This won't work if the width can not be read from the firmware. IIRC the pegasos has such bug. I should have a look at that... Feel free to apply the patch. :-) Thanks, Marco