From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Dvj0E-0007uq-T7 for mharc-grub-devel@gnu.org; Thu, 21 Jul 2005 17:54:51 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Dvj0B-0007rx-4j for grub-devel@gnu.org; Thu, 21 Jul 2005 17:54:47 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Dvj08-0007pj-96 for grub-devel@gnu.org; Thu, 21 Jul 2005 17:54:45 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Dvj07-0007lM-H8 for grub-devel@gnu.org; Thu, 21 Jul 2005 17:54:43 -0400 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Dvj74-0001DO-2U for grub-devel@gnu.org; Thu, 21 Jul 2005 18:01:54 -0400 Received: from vscan-cn.han.nl (venus.han.nl [145.74.65.6]) by mail-cn.han.nl (Postfix) with ESMTP id 7CBC78D37 for ; Thu, 21 Jul 2005 23:51:50 +0200 (CEST) Received: from mail-cn.han.nl ([145.74.66.11]) by vscan-cn.han.nl (venus.han.nl [145.74.65.6]) (amavisd-new, port 10024) with ESMTP id 00461-05 for ; Thu, 21 Jul 2005 22:59:29 +0200 (CEST) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id 2046C8CF7 for ; Thu, 21 Jul 2005 23:51:48 +0200 (CEST) Received: from localhost.localdomain (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id B76A9C047 for ; Thu, 21 Jul 2005 23:51:47 +0200 (CEST) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <20050719230122.F19A64BEAD@ws1-1.us4.outblaze.com> From: Marco Gerards Date: Thu, 21 Jul 2005 23:51:48 +0200 In-Reply-To: <20050719230122.F19A64BEAD@ws1-1.us4.outblaze.com> (Ruslan Nikolaev's message of "Tue, 19 Jul 2005 18:01:22 -0500") Message-ID: <87br4v6d57.fsf@student.han.nl> User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new (2.2.0) at vscan-cn.han.nl Subject: Re: [PATCH] ELF64 and changelog and 4Gb X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2005 21:54:48 -0000 "Ruslan Nikolaev" writes: >> I agree. This is more readable. > > I can change it of course... But it is not so bad: > > 1. if elf class == 64 => using ELF64 validate & loading code > > 2. else: > > - validate header by grub_dl_check_header(). Function > grub_dl_check_header() also will check that elf class is 32-bit. The important thing to remember is that GRUB support more machines than the PC and other loaders than just multiboot. So having a ELF32 and ELF64 loader like Hollis suggested would be the right thing to do. It will mean more shared code and a clean solution. Thanks, Marco