From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1D3Ilb-0002Nd-EO for mharc-grub-devel@gnu.org; Mon, 21 Feb 2005 13:58:47 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1D3Igx-0001Ng-Ij for grub-devel@gnu.org; Mon, 21 Feb 2005 13:54:00 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1D3Igm-0001IA-4d for grub-devel@gnu.org; Mon, 21 Feb 2005 13:53:50 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D3Igl-0001Cw-Nk for grub-devel@gnu.org; Mon, 21 Feb 2005 13:53:47 -0500 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1D3INh-0006Cu-Vj for grub-devel@gnu.org; Mon, 21 Feb 2005 13:34:06 -0500 Received: from vscan-cn.han.nl (venus.han.nl [145.74.65.6]) by mail-cn.han.nl (Postfix) with ESMTP id 754469CDA for ; Mon, 21 Feb 2005 19:30:19 +0100 (CET) Received: from mail-cn.han.nl ([145.74.66.11]) by vscan-cn.han.nl (venus.han.nl [145.74.65.6]) (amavisd-new, port 10024) with ESMTP id 28539-01 for ; Mon, 21 Feb 2005 19:30:18 +0100 (CET) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id 1F3CC9CD4 for ; Mon, 21 Feb 2005 19:30:18 +0100 (CET) Received: from localhost.localdomain (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id DCEA7C068 for ; Mon, 21 Feb 2005 19:30:17 +0100 (CET) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <20050219233439.GA17519@miracle> <200502201439.20815.okuji@enbug.org> <346f53d6be98efc620fc845c6407a0cf@penguinppc.org> From: Marco Gerards Date: Mon, 21 Feb 2005 19:30:18 +0100 In-Reply-To: <346f53d6be98efc620fc845c6407a0cf@penguinppc.org> (Hollis Blanchard's message of "Sun, 20 Feb 2005 10:38:54 -0600") Message-ID: <87bradpxz9.fsf@student.han.nl> User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new (2.2.0) at vscan-cn.han.nl Subject: Re: [patch] PPC build fixes X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Feb 2005 18:58:46 -0000 Hollis Blanchard writes: > On Feb 20, 2005, at 7:39 AM, Yoshinori K. Okuji wrote: > >> On Sunday 20 February 2005 00:34, Hollis Blanchard wrote: >>> - grub_reboot and grub_halt in util/i386/pc/misc.c are not >>> architecture-specific, so have been moved to util/grub-emu.c. >> >> grub_halt is clearly arch-specific. Look at the definition grub_halt in >> PC. It takes one argument, while the PPC version does not. I expect >> that the same thing might happen in grub_reboot as well. > > Oops, I meant to convert that into using a more generic "flags" > argument, and then "no_apm" becomes one bit in it. How would that be? And how would the parser work? What if more options have to be added for other archs? I do not have a strong objection against using flags, I am just afraid it might be inadequate and that the current code is easier to maintain. Thanks, Marco