Re: [PATCH v8 5/7] clk: nuvoton: ma35d1: Reparent SYSPLL correctly

[Miquel Raynal <miquel.raynal@bootlin.com>]

On 05/10/2026 at 11:12:35 +02, Jerome Brunet <jbrunet@baylibre.com> wrote:

> On Sun 04 Oct 2026 at 23:19, Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
>> On 04/10/2026 at 20:55:50 GMT, sashiko-bot@kernel.org wrote:
>>
>>> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
>>> - [Low] clk: nuvoton: ma35d1: Modification of global static state
>>> during probe
>>
>> There is a single clock controller. Should never be a problem. I can
>> certainly move it in to more local scope if someone asks, but it's not
>> practically needed.
>
> I may be missing something key here but why is not in your defined
> indexes like the rest of the clocks ?

SYSPLL and its parent (HXT_GATE) are in the hws[] array. Are you
suggesting to use the hw_clk pointer directly there instead of using the
parent data structure as an envelope? Because the issue raised is the
global definition of the struct clk_parent_data and then its
modification (since I need to reference the hws[SYSPLL] pointer inside).

Thanks,
Miquèl