From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDE6CC5DF93 for ; Fri, 21 Aug 2026 13:41:23 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wxPUY-0004tk-9o; Fri, 21 Aug 2026 09:41:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wxPUX-0004sK-Ay for qemu-devel@nongnu.org; Fri, 21 Aug 2026 09:41:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wxPUV-0001bE-Rq for qemu-devel@nongnu.org; Fri, 21 Aug 2026 09:41:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787319662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l5hklJRTHWgUutr/ww9yTllh1Rzgl3sw9hyLzHs6BiM=; b=YYER7O7JgIuqAt8K8C6Kk0RRmCcCEqfZv488Xpci0NUtyoHw90+J3DgQMUStf7NA1EPq5q 8KxwuH9XKp20iwgy6O+E2WWwRtZGgt/59BbyEFrCFO8dxKewou0DtxdXWDOGHBkk6Msspv MRnGsW+vJI0LIhSmrfUY6/oaNPvF5xg= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-407-OEPYP0DyOzS4EqT1OO6X_g-1; Fri, 21 Aug 2026 09:41:01 -0400 X-MC-Unique: OEPYP0DyOzS4EqT1OO6X_g-1 X-Mimecast-MFC-AGG-ID: OEPYP0DyOzS4EqT1OO6X_g_1787319660 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E7F551955DE3; Fri, 21 Aug 2026 13:40:59 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.44.22.12]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5442918005BB; Fri, 21 Aug 2026 13:40:59 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 01F2B21E6920; Fri, 21 Aug 2026 15:40:57 +0200 (CEST) From: Markus Armbruster To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: qemu-devel@nongnu.org, Paolo Bonzini , Daniel P. =?utf-8?Q?Berrang=C3=A9?= , Michael Roth , Pierrick Bouvier , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH v3 01/74] qapi: add QAPITypeInfo struct definition In-Reply-To: <20260818-qom-qapi-v3-1-24b8bbbe3d86@redhat.com> (=?utf-8?Q?=22Marc-Andr=C3=A9?= Lureau"'s message of "Tue, 18 Aug 2026 15:10:28 +0400") References: <20260818-qom-qapi-v3-0-24b8bbbe3d86@redhat.com> <20260818-qom-qapi-v3-1-24b8bbbe3d86@redhat.com> Date: Fri, 21 Aug 2026 15:40:56 +0200 Message-ID: <87cxvbzj4n.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 9 X-Spam_score: 0.9 X-Spam_bar: / X-Spam_report: (0.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.341, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Marc-Andr=C3=A9 Lureau writes: > Introduce a minimal struct that pairs a QAPI type's internal name with > its "masked" introspection name. Generated constants of this type will > let QOM property registration carry a reliable reference to the QAPI > schema and possibly other associated data. > > The fields are populated in following commits. > > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > include/qapi/qapi-type-info.h | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/include/qapi/qapi-type-info.h b/include/qapi/qapi-type-info.h > new file mode 100644 > index 000000000000..97eb1d7bf490 > --- /dev/null > +++ b/include/qapi/qapi-type-info.h > @@ -0,0 +1,32 @@ > +/* > + * SPDX-License-Identifier: GPL-2.0-or-later > + */ > + > +#ifndef QAPI_TYPE_INFO_H > +#define QAPI_TYPE_INFO_H > + > +#include "qapi/util.h" > + > +/** > + * QAPITypeInfo - QAPI type metadata > + * > + * @name: QAPI type name (e.g. "str", "OnOffAuto", "int32List"). > + * QOM uses this as the property type string. > + * @masked_name: Name of the type in the QAPI introspection schema, assi= gned by > + * scripts/qapi code generator (e.g. "368"). Suggest 'Name of the type in output of query-qmp-schema (e.g. "368")'. > + * NULL for implicit types. Can this happen? I can't see any QAPITypeInfo with null @masked_name at the end of the series. > + * @lookup: QEnumLookup for this type, or NULL for non-enum types. Maybe ', null unless it's an enum type'. > + * visit_type_enum(), qapi_enum_parse(), and qapi_enum_lookup() > + * all rely on it. "It" is ambiguous: is it the @lookup pointer or the struct it points to? The latter is correct. Is the sentence useful? > + * @list: The list-type counterpart, or NULL if none exists. > + * str_type_info.list points to strList_type_info. qdev array > + * properties follow this to find the list type for their element. > + */ > +typedef struct QAPITypeInfo { > + const char *name; > + const char *masked_name; > + const QEnumLookup *lookup; > + const struct QAPITypeInfo *list; > +} QAPITypeInfo; > + > +#endif /* QAPI_TYPE_INFO_H */